fs: check closing_ in FileHandle::Close

Fix possible flaky failure. Keep uv_fs_close from being called twice on the same fd. Refs: #39464 Signed-off-by: James M Snell <[email protected]>
nodejs · Jul 20, 2021 · 71343ea · 71343ea
1 parent ad5dc4c
commit 71343ea
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/node_file.cc b/src/node_file.cc
@@ -237,7 +237,7 @@ BaseObjectPtr<BaseObject> FileHandle::TransferData::Deserialize(
 // JS during GC. If closing the fd fails at this point, a fatal exception
 // will crash the process immediately.
 inline void FileHandle::Close() {
-  if (closed_) return;
+  if (closed_ || closing_) return;
   uv_fs_t req;
   int ret = uv_fs_close(env()->event_loop(), &req, fd_, nullptr);
   uv_fs_req_cleanup(&req);