-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v15.7.0 proposal #37020
Merged
Merged
v15.7.0 proposal #37020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-URL: #36869 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Pooja D P <[email protected]> Reviewed-By: Harshitha K P <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
Fixes: #36185 PR-URL: #36190 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
This patch changes GetRsaKeyDetail to work in older supported versions of OpenSSL. Refs: openssl/openssl#10217 PR-URL: #36877 Refs: #36188 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #36735 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #36752 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #36734 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Pooja D P <[email protected]>
PR-URL: #36722 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Pooja D P <[email protected]>
PR-URL: #36733 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #36913 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Pooja D P <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #36882 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
This API exposes key details. It is conceptually different from the previously discussed keyObject.fields property since it does not give access to information that could compromise the security of the key, and the obtained information cannot be used to uniquely identify a key. The intended purpose is to determine "security properties" of keys, e.g. to generate a new key pair with the same parameters, or to decide whether a key is secure enough. closes #30045 PR-URL: #36188 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
PR-URL: #36896 Fixes: #36885 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Remove "How to Contribute in Issues". This is not Node.js-specific and is likely to cause many readers to tune out. If we want to include this kind of how-all-issue-trackers-are-intended-to-work information, let's link to an external source. But I think it's OK to simply remove it. Refs: nodejs/TSC#864 (comment) PR-URL: #36891 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Co-authored-by: Andrey Pechkurov <[email protected]> PR-URL: #36894 Refs: #34600 Reviewed-By: Andrey Pechkurov <[email protected]> Reviewed-By: James M Snell <[email protected]>
Given the effort to change the master branch to main, this may make sense as part of removing other references to the offending wording as well. Signed-off-by: Michael Dawson <[email protected]> PR-URL: #36851 Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
PR-URL: #36072 Fixes: #34110 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
PR-URL: #36934 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Pooja D P <[email protected]>
PR-URL: #36915 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
PR-URL: #36912 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #36914 Refs: #36190 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rich Trott <[email protected]>
PR-URL: #36700 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
PR-URL: #36947 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #36951 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Myles Borins <[email protected]>
PR-URL: #36911 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #36848 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Guy Bedford <[email protected]>
This section isn't particularly useful in this context and contributes to making the document longer and less effective. This is part of a larger effort to make the contributing docs brief, informative, and friendly. Refs: nodejs/TSC#864 (comment) PR-URL: #36905 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
The replicated issue template is out of date. There isn't much reason to replicate it here anyway, so let's remove it and describe what the user should do briefly. PR-URL: #36908 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Pooja D P <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #36862 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Daniele Belardi <[email protected]>
PR-URL: #36863 Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: #36966 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Fixes: #23723 PR-URL: #36223 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #36740 Reviewed-By: Antoine du Hamel <[email protected]>
Instead of hard-coding the field count. PR-URL: #36991 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
Refs: https://github.com/unicode-org/icu/releases/tag/release-68-2 PR-URL: #36980 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #36980 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Our current minimum ICU is 67, so we don't need to support those anymore PR-URL: #36980 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #36982 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #37018 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
ruyadorno
added a commit
that referenced
this pull request
Jan 25, 2021
PR-URL: #37020 Notable changes: * buffer: * introduce Blob (James M Snell) [#36811](#36811) * add base64url encoding option (Filip Skokan) [#36952](#36952) * doc: * add @iansu to collaborators (Ian Sutherland) [#36951](#36951) * add @RaisinTen to collaborators (Darshan Sen) [#36998](#36998) * add @miladfarca to collaborators (Milad Fa) [#36934](#36934) * fs: * allow position parameter to be a BigInt in read and readSync (raisinten) [#36190](#36190) * http: * attach request as res.req (Ian Storm Taylor) [#36505](#36505) * expose urlToHttpOptions utility (Yongsheng Zhang) [#35960](#35960)
ruyadorno
force-pushed
the
v15.7.0-proposal
branch
from
January 25, 2021 03:21
78b8cde
to
5fe188e
Compare
@tniessen I removed the mentioned commit to give you and the other collaborators some extra time to discuss, feel free to add the appropriate label in that original PR if you want to avoid having it landing in an upcoming release. |
This comment has been minimized.
This comment has been minimized.
MylesBorins
approved these changes
Jan 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR-URL: #37020 Notable changes: * buffer: * introduce Blob (James M Snell) [#36811](#36811) * add base64url encoding option (Filip Skokan) [#36952](#36952) * doc: * add @iansu to collaborators (Ian Sutherland) [#36951](#36951) * add @RaisinTen to collaborators (Darshan Sen) [#36998](#36998) * add @miladfarca to collaborators (Milad Fa) [#36934](#36934) * fs: * allow position parameter to be a BigInt in read and readSync (raisinten) [#36190](#36190) * http: * attach request as res.req (Ian Storm Taylor) [#36505](#36505) * expose urlToHttpOptions utility (Yongsheng Zhang) [#35960](#35960)
ruyadorno
force-pushed
the
v15.7.0-proposal
branch
from
January 25, 2021 22:18
5fe188e
to
2c0edbc
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ruyadorno
added a commit
that referenced
this pull request
Jan 26, 2021
PR-URL: #37020 Notable changes: * buffer: * introduce Blob (James M Snell) [#36811](#36811) * add base64url encoding option (Filip Skokan) [#36952](#36952) * doc: * add @iansu to collaborators (Ian Sutherland) [#36951](#36951) * add @RaisinTen to collaborators (Darshan Sen) [#36998](#36998) * add @miladfarca to collaborators (Milad Fa) [#36934](#36934) * fs: * allow position parameter to be a BigInt in read and readSync (raisinten) [#36190](#36190) * http: * attach request as res.req (Ian Storm Taylor) [#36505](#36505) * expose urlToHttpOptions utility (Yongsheng Zhang) [#35960](#35960)
ruyadorno
added a commit
to ruyadorno/nodejs.org
that referenced
this pull request
Jan 26, 2021
ruyadorno
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2021-01-26, Version 15.7.0 (Current), @ruyadorno
Notable changes
position
parameter to be aBigInt
in read and readSync (raisinten) #36190Commits
2692d0bd5e
] - (SEMVER-MINOR) buffer: introduce Blob (James M Snell) #36811832cd015d5
] - (SEMVER-MINOR) buffer: add base64url encoding option (Filip Skokan) #36952acb1a71a7d
] - build: fix compiling against openssl with no-psk (Caleb ツ Everett) #3688168ffe5a406
] - (SEMVER-MINOR) crypto: experimental (Ed/X)25519/(Ed/X)448 support (James M Snell) #36879b7d8e61ef1
] - crypto: fix randomInt bias (Tobias Nießen) #368941149af6265
] - (SEMVER-MINOR) crypto: add keyObject.asymmetricKeyDetails for asymmetric keys (Filip Skokan) #361880398167b35
] - crypto: fix WebCrypto import of RSA-PSS keys (Tobias Nießen) #368779ffe67b3a9
] - deps: upgrade npm to 7.4.3 (Ruy Adorno) #37018d684cbdda3
] - deps: update ICU to 68.2 (Michaël Zasso) #36980fdb9812134
] - deps: V8: cherry-pick fe191e8d05cc (Benjamin Coe) #369566f773fbe84
] - deps: upgrade npm to 7.4.2 (Ruy Adorno) #3695395889c1fdc
] - doc: fix maintaining ICU guide (Michaël Zasso) #369800c9e2d0650
] - doc: add @RaisinTen to collaborators (Darshan Sen) #3699801c24aafc2
] - doc: fix typo in http.server.requestTimout docs (alexbs) #369877083d99803
] - doc: add performance notes for fs.readFile (James M Snell) #368805693ed9df1
] - doc: clarify maxSockets option of http.Agent (Pooja D P) #369419531922a76
] - doc: remove pull-requests.md preamble (Rich Trott) #369604980cf70c3
] - doc: fix module.isPreloading documentation (Antoine du Hamel) #3694448b6781151
] - doc: fix crypto.generateKeySync aes allowed length list (Filip Skokan) #36928120db2c169
] - doc: fix grammar and link to QUIC in changelog (Dan Dascalescu) #36959af0f0a0f65
] - doc: fix percentile range in perf_hooks.md (raisinten) #369388cf280d9ab
] - doc: improve perf_hooks docs (Juan José Arboleda) #369093ea37c2d67
] - doc: fix invalid HTML in doc template (Rich Trott) #36930eaf378aa46
] - doc: remove issue template duplication from contributing docs (Rich Trott) #369087a794417f3
] - doc: remove resolving-a-bug-report from contributing docs (Rich Trott) #36905707b97307d
] - doc: use ESM syntax for WASI example (Antoine du Hamel) #368485a9a07e7cd
] - doc: add iansu to collaborators (Ian Sutherland) #36951aa3bc74cd6
] - doc: fixup typo in metadata entry (James M Snell) #3694722e29ccfa3
] - doc: add alternative version links to the packages page (Filip Skokan) #3691580c84a1136
] - doc: add miladfarca to collaborators (Milad Fa) #36934e73b1072f3
] - doc: update tls test to use better terminology (Michael Dawson) #368515cbf638c06
] - doc: remove unnecessary contributing.md section (Rich Trott) #36891f99b38fedd
] - doc: wrap TOC in a <details> tag (Mattia Pontonio) #3689682eccddf1e
] - doc: update fs.l/statSync API history for throwIfNoEntry (Andrew Casey) #3688270cd43c32e
] - doc: change "it's" to "its" where necessary (Tobias Nießen) #3691302a8f52040
] - doc: fix indentation on http2 doc entry (Rich Trott) #36869abf0477c9e
] - events: remove error listener on signal abort (ZiJian Liu) #36969c4cdf1d830
] - (SEMVER-MINOR) fs: allowposition
parameter to be aBigInt
in read and readSync (raisinten) #361900ee168c896
] - (SEMVER-MINOR) http: attach request as res.req (Ian Storm Taylor) #3650582c05f5def
] - http: abortIncoming only on socket close (Robert Nagy) #36821aa7243e3d4
] - http: refactor ClientRequest destroy (Robert Nagy) #3686380051abfcb
] - http: cleanup ClientRequest oncreate (Robert Nagy) #36862f5b8e7b068
] - http2: refactor to avoid unsafe array iteration (Antoine du Hamel) #3670091f94abbd1
] - lib: refactor to use validateArray (ZiJian Liu) #36982b3ca53985b
] - lib: remove non used getter inlib/perf\_hooks.js
(Juan José Arboleda) #36907f2ac4bb8e2
] - lib: expose primordials object (Antoine du Hamel) #36872850d3578b6
] - lib: refactorprimordials.makeSafe
to use more primordials (ExE Boss) #36865b86c48cc91
] - lib: refactor source_map to use more primordials (Antoine du Hamel) #367331ef92f61fa
] - lib: refactor source_map to avoid unsafe array iteration (Antoine du Hamel) #36734543ecbdbd8
] - module: simplify tryStatSync with throwIfNoEntry option (Antoine du Hamel) #36971d3f7280e75
] - os: performance improvement in vector allocation (Yash Ladha) #36748327a2b7801
] - perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param is NaN (ZiJian Liu) #36937d29c0a9bb7
] - repl: refactor to avoid unsafe array iteration (raisinten) #36663eef77e46c4
] - src: use BaseObject::kInteralFieldCount in Blob (Joyee Cheung) #369919254791528
] - src: replace push_back with emplace_back in debug_utils (raisinten) #368973c12941359
] - src: use BaseObject::kInternalFieldCount in X509Certificate constructor (Joyee Cheung) #368923a122aa246
] - test: mark flaky tests on IBM i (Richard Lau) #36986d73d58d595
] - (SEMVER-MINOR) test: add wpt tests for Blob (Michaël Zasso) #36811951a78bc34
] - test: increase buffer list coverage (Emil Sivervik) #366883d20415871
] - test: fix warning in test_environment.cc (raisinten) #36846e285a7a76d
] - test: remove unused ecdhPeerKey (Daniel Bevenius) #36942ba87be0b0e
] - test: improve coverage forModule
getters (Juan José Arboleda) #36950c7dd9c8c69
] - test: skip internet for test-npm-install (Ruy Adorno) #369333bbe9a5588
] - test: improve coverage on worker threads (Juan José Arboleda) #36910f589bb2052
] - test: improve coverage atlib/internal/vm/module.js
(Juan José Arboleda) #368988a8241529e
] - Revert "test: mark test-cluster-bind-privileged-port flaky on arm" (Rod Vagg) #3688499c15909ad
] - test: fixup flaky test-crypto-x509 on windows (James M Snell) #36966c2ec15aff6
] - test: check mustCall errors in test-fs-read-type (Tobias Nießen) #3691430b2aac98a
] - test: fix variable name for non-RSA keys (Tobias Nießen) #36912d97917faef
] - test,benchmark: stop requiring URL and URLSearchParams (raisinten) #36927864b97b24d
] - tls: use recently added matching SecureContext in default SNICallback (Mateusz Krawczuk) #3607261257013f6
] - tools: cleanup old ICU version-specific fixes (Michaël Zasso) #369808e02b53b09
] - tools: update ESLint to 7.18.0 (Colin Ihrig) #369558dc8adc782
] - tools: add support for top-level await syntax in linter (Antoine du Hamel) #369114cd471e685
] - tools,doc: list the stability status of each API (Zijian Liu) #36223889654d36c
] - url: align url format behavior with browsers (ZiJian Liu) #3690364fed319ef
] - (SEMVER-MINOR) url: expose urlToHttpOptions utility (Yongsheng Zhang) #35960d676324b66
] - util: preferReflect.ownKeys(…)
(ExE Boss) #367400d719476e0
] - vm: refactor to avoid unsafe array iteration (Antoine du Hamel) #36752bf695ebdb1
] - worker: refactor to avoid unsafe array iteration (Antoine du Hamel) #36735403b595ef5
] - zlib: refactor to avoid unsafe array iteration (Antoine du Hamel) #36722