tls: use the most recently added matching SecureContext in default SN… #36072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
mscdex
reviewed
Nov 10, 2020
mscdex
reviewed
Nov 10, 2020
| // connections. | ||
| // Connection to subdomain 'a' is made when the 'bad' secure context is | ||
| // the only one in use. | ||
| if ('a.example.com' === c.servername) { |
There was a problem hiding this comment.
minor nit: we could be more strict here and assert that these are equal depending on the current step, same for the other conditional below
Trott
reviewed
Nov 12, 2020
Trott
approved these changes
Nov 12, 2020
|
@nodejs/crypto @addaleax |
|
Rebased. cc @addaleax |
github-actions
bot
removed
the
request-ci
|
Did a clear rebase, because the previous one failed. @Trott you might want to request another CI. |
addaleax
approved these changes
Jan 7, 2021
PR-URL: nodejs#36072 Fixes: nodejs#34110 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
|
Landed in 8cf5281 |
ruyadorno
pushed a commit
that referenced
this pull request
Jan 22, 2021
PR-URL: #36072 Fixes: #34110 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, ruined the previous PR (#34638) with a merge.
Fixes: #34110
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes