-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: check mustCall errors in test-fs-read-type #36914
Closed
tniessen
wants to merge
1
commit into
nodejs:master
from
tniessen:test-make-checks-stricter-in-fs-read-type
Closed
test: check mustCall errors in test-fs-read-type #36914
tniessen
wants to merge
1
commit into
nodejs:master
from
tniessen:test-make-checks-stricter-in-fs-read-type
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
approved these changes
Jan 13, 2021
richardlau
approved these changes
Jan 13, 2021
aduh95
approved these changes
Jan 13, 2021
aduh95
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Jan 13, 2021
Trott
approved these changes
Jan 14, 2021
tniessen
added a commit
that referenced
this pull request
Jan 15, 2021
PR-URL: #36914 Refs: #36190 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Landed in d7b1866, thanks for reviewing. |
ruyadorno
pushed a commit
that referenced
this pull request
Jan 22, 2021
PR-URL: #36914 Refs: #36190 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
tniessen
removed
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Jan 23, 2021
targos
pushed a commit
that referenced
this pull request
Aug 8, 2021
PR-URL: #36914 Refs: #36190 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rich Trott <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Aug 12, 2021
PR-URL: #36914 Refs: #36190 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rich Trott <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Aug 31, 2021
PR-URL: #36914 Refs: #36190 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rich Trott <[email protected]>
foxxyz
pushed a commit
to foxxyz/node
that referenced
this pull request
Oct 18, 2021
PR-URL: nodejs#36914 Refs: nodejs#36190 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The async tests, which are modified in this PR, appear to be the async equivalents of these synchronous tests:
node/test/parallel/test-fs-read-type.js
Lines 222 to 239 in 251a0ff
The async tests did not check for errors properly.
Refs: #36190