fs: remove experimental warning for fs.promises #26581

addaleax · 2019-03-11T10:22:59Z

This has been warning for long enough, without any API changes
in the last few months.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

nodejs-github-bot · 2019-03-11T10:23:02Z

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2860/pipeline

devsnek · 2019-03-11T12:37:35Z

we still have the unsolved issue of it needing to be first class accessable to esm

addaleax · 2019-03-11T13:10:30Z

@devsnek Is that a blocker for you for this PR?

devsnek · 2019-03-11T13:16:05Z

@addaleax I think so. would it be unreasonable to move this back to fs/promises or at least add that as an alias?

benjamingr · 2019-03-11T15:34:20Z

I think so. would it be unreasonable to move this back to fs/promises or at least add that as an alias?

That is blocked on scoping Node's modules, so it would need to be @nodejs/fs or something similar. That's why fs/promises was reverted to begin with.

devsnek · 2019-03-11T15:36:38Z

@benjamingr then it sounds like we should figure out the rest of the scoping

Trott · 2019-03-11T19:09:45Z

This leaves it as experimental in the docs. That's intentional? (I'd prefer we make it stable in the docs and label this semver-major but that's just me!)

jasnell · 2019-03-11T19:50:27Z

Perhaps it's time just to take it out of experimental?

antsmartian

🎉

jdalton · 2019-03-12T06:56:21Z

lib/fs.js

@@ -1927,11 +1927,8 @@ Object.defineProperties(fs, {
    configurable: true,
    enumerable: false,
    get() {
-      if (promises === null) {


Please make this property enumerable: true now that it's no longer experimental.
It also no longer needs to be a getter.

@jdalton Thanks, done :)

addaleax · 2019-03-12T11:06:39Z

@jasnell @Trott I’m also okay with completely moving it out of experimental status, yes.

I’m not sure about the scoping thing. It doesn’t feel to me like we should block features until we’ve figured that out, it’s been a long time and there hasn’t been much movement on it recently.

nodejs-github-bot · 2019-03-25T18:04:11Z

CI: https://ci.nodejs.org/job/node-test-pull-request/21891/

BridgeAR · 2019-03-25T18:04:45Z

I marked this as author ready. It seems we can still revise the actual experimental status in another PR and that should not block the message from being removed.

targos · 2019-03-30T12:39:53Z

The tests failed everywhere.

This has been warning for long enough, without any API changes in the last few months.

Trott · 2019-03-30T21:43:28Z

(Removed author ready because of failing test, but feel free to re-add, as I suspect the test fix is likely to be something small and straightforward.)

addaleax · 2019-03-30T21:51:08Z

@targos @Trott Yes, thanks – this should be fixed now.

I’ve also aligned this PR with what #26592 did, i.e. moved the API to Stable rather than just removing the warning.

This has been warning for long enough, without any API changes in the last few months. PR-URL: #26581 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: James M Snell <[email protected]> Signed-off-by: Beth Griggs <[email protected]>

Notable changes: - child_process: doc deprecate ChildProcess.\_channel (cjihrig) [#26982](#26982) - deps: update nghttp2 to 1.37.0 (gengjiawen) [#26990](#26990) - dns: - make dns.promises enumerable (cjihrig) [#26592](#26592) - remove dns.promises experimental warning (cjihrig) [#26592](#26592) - fs: remove experimental warning for fs.promises (Anna Henningsen) [#26581] (#26581) - stream: make Symbol.asyncIterator support stable (Matteo Collina) [#26989](#26989) - worker: use copy of process.env (Anna Henningsen) [#26544](#26544) PR-URL: #27163

This has been warning for long enough, without any API changes in the last few months. PR-URL: #26581 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: James M Snell <[email protected]>

Notable changes: - **deps**: upgrade openssl sources to 1.1.1d (Sam Roberts) [#29921](#29921) - **dns**: remove dns.promises experimental warning (cjihrig) [#26592](#26592) - **fs**: remove experimental warning for fs.promises (Anna Henningsen) [#26581](#26581) - **n-api**: mark version 5 N-APIs as stable (Gabriel Schulhof) [#29401](#29401) - **stream**: make Symbol.asyncIterator support stable (Matteo Collina) [#26989](#26989) PR-URL: #29875

Notable changes: - **deps**: update npm to 6.11.3 (claudiahdz) [#29430](#29430) - **deps**: upgrade openssl sources to 1.1.1d (Sam Roberts) [#29921](#29921) - **dns**: remove dns.promises experimental warning (cjihrig) [#26592](#26592) - **fs**: remove experimental warning for fs.promises (Anna Henningsen) [#26581](#26581) - **n-api**: mark version 5 N-APIs as stable (Gabriel Schulhof) [#29401](#29401) - **stream**: make Symbol.asyncIterator support stable (Matteo Collina) [#26989](#26989) PR-URL: #29875

Notable changes: * crypto: * add support for chacha20-poly1305 for AEAD (chux0519) #24081 * increase maxmem range from 32 to 53 bits (Tobias Nießen) #28799 * deps: * update npm to 6.11.3 (claudiahdz) #29430 * upgrade openssl sources to 1.1.1d (Sam Roberts) #29921 * dns: * remove dns.promises experimental warning (cjihrig) #26592 * fs: * remove experimental warning for fs.promises (Anna Henningsen) #26581 * http: * makes response.writeHead return the response (Mark S. Everitt) #25974 * http2: * makes response.writeHead return the response (Mark S. Everitt) #25974 * n-api: * make func argument of napi\_create\_threadsafe\_function optional (legendecas) #27791 * mark version 5 N-APIs as stable (Gabriel Schulhof) #29401 * implement date object (Jarrod Connolly) #25917 * process: * add --unhandled-rejections flag (Ruben Bridgewater) #26599 * stream: * implement Readable.from async iterator utility (Guy Bedford) #27660 * make Symbol.asyncIterator support stable (Matteo Collina) #26989 PR-URL: #29875

The current Loc presubmit are doing two checks: check_localizable_resources and check_localizability (Details of what they are checking: https://docs.google.com/document/d/1L6TkT2-42MMQ72ZSBMFwUaq7M6mDgA2X0x8oHHKaV_U/edit#heading=h.w1no7qaa0mi0) This CL merge two checks into one single check. check_localizability are modified into a utils file, and check_localizable_resources will also run those localizability checks when the files are visited. By doing this, we avoid the extra call to node during presubmit, and all files and nodes will only be visited once. Also adding these fixes https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2370103 Fix: - Pass the fullpath for comparison.(itemPath) - Normalize comparison between paths - using native fs.promises instead of promisify (nodejs/node#26581) Bug: 1116989 Change-Id: I054040d83a65b5f798a21c040096422e287bc799 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2381320 Reviewed-by: Vidal Diazleal <[email protected]> Reviewed-by: Tim van der Lippe <[email protected]> Reviewed-by: Simon Zünd <[email protected]> Commit-Queue: Christy Chen <[email protected]>

nodejs-github-bot added the fs Issues and PRs related to the fs subsystem / file system. label Mar 11, 2019

lpinca approved these changes Mar 11, 2019

View reviewed changes

benjamingr approved these changes Mar 11, 2019

View reviewed changes

cjihrig mentioned this pull request Mar 11, 2019

dns: remove dns.promises experimental warning #26592

Merged

3 tasks

cjihrig approved these changes Mar 11, 2019

View reviewed changes

vsemozhetbyt mentioned this pull request Mar 11, 2019

Preparation for Node.js 12 nodejs/Release#417

Closed

6 tasks

Trott added semver-major PRs that contain breaking changes and should be released in the next major version. and removed semver-major PRs that contain breaking changes and should be released in the next major version. labels Mar 11, 2019

antsmartian approved these changes Mar 12, 2019

View reviewed changes

jdalton reviewed Mar 12, 2019

View reviewed changes

BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 25, 2019

addaleax added 2 commits March 30, 2019 22:34

fs: remove experimental warning for fs.promises

5cad376

This has been warning for long enough, without any API changes in the last few months.

fixup! fs: remove experimental warning for fs.promises

6956fa3

Trott removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 30, 2019

fixup! fs: remove experimental warning for fs.promises

b9154d3

addaleax force-pushed the fs-promises-no-experimental-warning branch from 894643a to b9154d3 Compare March 30, 2019 21:50

BethGriggs mentioned this pull request Apr 9, 2019

v11.14.0 proposal #27163

Merged

dnalborczyk mentioned this pull request Apr 15, 2019

test: fs promises, fixes comment, simplifies test #27242

Merged

4 tasks

saschanaz mentioned this pull request Apr 16, 2019

refactor(tools): use fs.promises API speced/respec#2282

Merged

kibertoad mentioned this pull request May 28, 2019

fs Promises API still marked as experimental for Node 10 #27944

Closed

lundibundi mentioned this pull request Jun 21, 2019

Replace callbacks with promises metarhia/filestorage#12

Open

BethGriggs added the lts-watch-v10.x label Aug 20, 2019

BethGriggs added land-on-v10.x and removed lts-watch-v10.x labels Oct 17, 2019

BethGriggs mentioned this pull request Oct 18, 2019

v10.17.0 proposal #29875

Merged

segayuu mentioned this pull request Nov 5, 2019

Reaction to fs.promises API hexojs/hexo-fs#47

Open

samouri mentioned this pull request Jan 8, 2020

♻️ Remove dependency on 'fs-extra' by utilizing nodejs builtin fs.promises ampproject/amphtml#26263

Closed

iiroj mentioned this pull request Jan 31, 2020

ExperimentalWarning: The fs.promises API is experimental lint-staged/lint-staged#785

Closed

goiblas mentioned this pull request Feb 28, 2020

ExperimentalWarning: The fs.promises API is experimental goiblas/gulp-add-source-picture#2

Closed

tmathern mentioned this pull request Mar 26, 2020

latest version warnings image-size/image-size#261

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fs: remove experimental warning for fs.promises #26581

fs: remove experimental warning for fs.promises #26581

addaleax commented Mar 11, 2019

nodejs-github-bot commented Mar 11, 2019

devsnek commented Mar 11, 2019

addaleax commented Mar 11, 2019

devsnek commented Mar 11, 2019

benjamingr commented Mar 11, 2019

devsnek commented Mar 11, 2019

Trott commented Mar 11, 2019

jasnell commented Mar 11, 2019

antsmartian left a comment

jdalton Mar 12, 2019 •

edited

Loading

addaleax Mar 12, 2019

addaleax commented Mar 12, 2019

nodejs-github-bot commented Mar 25, 2019

BridgeAR commented Mar 25, 2019

targos commented Mar 30, 2019

Trott commented Mar 30, 2019 •

edited

Loading

addaleax commented Mar 30, 2019

fs: remove experimental warning for fs.promises #26581

fs: remove experimental warning for fs.promises #26581

Conversation

addaleax commented Mar 11, 2019

Checklist

nodejs-github-bot commented Mar 11, 2019

devsnek commented Mar 11, 2019

addaleax commented Mar 11, 2019

devsnek commented Mar 11, 2019

benjamingr commented Mar 11, 2019

devsnek commented Mar 11, 2019

Trott commented Mar 11, 2019

jasnell commented Mar 11, 2019

antsmartian left a comment

Choose a reason for hiding this comment

jdalton Mar 12, 2019 • edited Loading

Choose a reason for hiding this comment

addaleax Mar 12, 2019

Choose a reason for hiding this comment

addaleax commented Mar 12, 2019

nodejs-github-bot commented Mar 25, 2019

BridgeAR commented Mar 25, 2019

targos commented Mar 30, 2019

Trott commented Mar 30, 2019 • edited Loading

addaleax commented Mar 30, 2019

jdalton Mar 12, 2019 •

edited

Loading

Trott commented Mar 30, 2019 •

edited

Loading