Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs Promises API still marked as experimental for Node 10 #27944

Closed
kibertoad opened this issue May 28, 2019 · 3 comments
Closed

fs Promises API still marked as experimental for Node 10 #27944

kibertoad opened this issue May 28, 2019 · 3 comments
Labels
doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. question Issues that look for answers.

Comments

@kibertoad
Copy link
Contributor

https://nodejs.org/dist/latest-v10.x/docs/api/fs.html still reports fs-promises API to be experimental, even though it was declared stable in #26581
Shouldn't same apply to Node 10 as well, or some code still needs to be backported first?

@lpinca
Copy link
Member

lpinca commented May 29, 2019

I think the PR has not been backported to v10.x yet.

@lpinca lpinca added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels May 29, 2019
@BridgeAR
Copy link
Member

@lpinca is correct that this is not yet backported. This will likely be the case in later versions.

@BridgeAR BridgeAR added the question Issues that look for answers. label May 29, 2019
@billiegoose
Copy link

For anyone else running into this via Google, I found a way to distinguish between the two cases. In v12 the promises property is enumerable:

v10 - prints warning

> Object.getOwnPropertyDescriptor(fs, 'promises')
{ get: [Function: get],
  set: undefined,
  enumerable: false,
  configurable: true }

v12 - does not

> Object.getOwnPropertyDescriptor(fs, 'promises')
{
  get: [Function: get],
  set: undefined,
  enumerable: true,
  configurable: true
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. question Issues that look for answers.
Projects
None yet
Development

No branches or pull requests

4 participants