Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Remove dependency on 'fs-extra' by utilizing nodejs builtin fs.promises #26263

Closed
wants to merge 1 commit into from

Conversation

samouri
Copy link
Member

@samouri samouri commented Jan 8, 2020

Summary
The nodejs builtin fs.promises is no longer experimental. Therefore I think its fair to remove our dependency on fs-extra.

@amp-owners-bot
Copy link

amp-owners-bot bot commented Jan 8, 2020

Hey @erwinmombay, these files were changed:

  • build-system/babel-plugins/babel-plugin-transform-log-methods/index.js
  • build-system/compile/single-pass.js

Hey @jridgewell, these files were changed:

  • build-system/babel-plugins/babel-plugin-transform-log-methods/index.js

@samouri
Copy link
Member Author

samouri commented Jan 8, 2020

Argh, this idea didn't work. We utilize some of the extra fs-extra functionality other than just promises (e.g. creating files in nonexistent directories).

@samouri samouri closed this Jan 8, 2020
@samouri samouri deleted the fs-promises branch January 8, 2020 23:03
@rsimha
Copy link
Contributor

rsimha commented Jan 8, 2020

Argh, this idea didn't work. We utilize some of the extra fs-extra functionality other than just promises (e.g. creating files in nonexistent directories).

Yep, I tried removing as many of the unnecessary uses of fs-extra as possible when I worked on #25822. But you still earn multiple brownie points for attempting to do a good-citizenship cleanup of this sort 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants