Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🏗🚮 Replace bluebird promises with node's native promises #25822

Merged
merged 4 commits into from
Dec 4, 2019
Merged

🏗🚮 Replace bluebird promises with node's native promises #25822

merged 4 commits into from
Dec 4, 2019

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Dec 2, 2019 •
edited
Loading

Several of AMP's gulp tasks use the bluebird package for promise functionality because they were written at a time when node did not natively support promises.

PR highlights:

  • Replaces Promise from bluebird with node's native Promise
  • Replaces Promise.all from bluebird with node's native Promise.all
  • Replaces promisify from bluebird with node's native util.promisify
  • Replaces promisifyAll from bluebird with native promise APIs of fs and fs-extra
  • Completely removes bluebird from package.json

References:

Closes #25810
Resolves #25318 (comment)

@rsimha rsimha self-assigned this Dec 2, 2019
@amp-owners-bot
Copy link

amp-owners-bot bot commented Dec 2, 2019

Hey @alanorozco, these files were changed:

  • build-system/server/app-index/index.js
  • build-system/server/app-index/test/test-self.js
  • build-system/server/app-index/util/listing.js

This was referenced Dec 2, 2019
Merged
Closed
kristoferbaxter
kristoferbaxter approved these changes Dec 2, 2019
View reviewed changes
build-system/server/app-index/index.js Outdated Show resolved Hide resolved
rcebulko
rcebulko approved these changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@rcebulko rcebulko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alanorozco
alanorozco approved these changes Dec 3, 2019
View reviewed changes
Copy link
Member

@alanorozco alanorozco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @rsimha!

@rsimha rsimha merged commit b59a815 into ampproject:master Dec 4, 2019
@rsimha rsimha deleted the 2019-12-02-BlueBird branch December 4, 2019 16:32
@rsimha rsimha mentioned this pull request Dec 5, 2019
Merged
@rsimha rsimha mentioned this pull request Dec 17, 2019
Merged
micajuine-ho pushed a commit to micajuine-ho/amphtml that referenced this pull request Dec 27, 2019
@rsimha
🏗🚮 Replace bluebird promises with node's native promises (ampprojec…
997d2f5 
…t#25822)
@rsimha rsimha mentioned this pull request Jan 8, 2020
Closed
@rsimha rsimha mentioned this pull request Jul 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estherkim estherkim estherkim approved these changes

@rcebulko rcebulko rcebulko approved these changes

@danielrozenberg danielrozenberg danielrozenberg approved these changes

@erwinmombay erwinmombay erwinmombay approved these changes

@alanorozco alanorozco alanorozco approved these changes

@kristoferbaxter kristoferbaxter kristoferbaxter approved these changes

Assignees

@rsimha rsimha

Labels
cla: yes WG: infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@rsimha @kristoferbaxter @alanorozco @erwinmombay @danielrozenberg @rcebulko @estherkim @googlebot