Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check CI failures before land #422

Merged
merged 1 commit into from
May 26, 2020

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented May 22, 2020

Closes #377.

We were previously checking for actual CI results in GitHub Actions-based CI, but not for Jenkins - this adds in and updates logic to aggregate Jenkins results into landing preparation.

Using nodejs/node#33498 as a test case:

Before:
Screen Shot 2020-05-22 at 9 58 11 AM

After:
Screen Shot 2020-05-22 at 9 57 28 AM

cc @sam-github @joyeecheung @targos

@codebytere codebytere requested review from joyeecheung and targos May 22, 2020 16:59
@codebytere codebytere marked this pull request as draft May 22, 2020 17:03
@codebytere codebytere force-pushed the pr-checker-jenkins-failures branch from 75a1028 to 0ca7fc2 Compare May 22, 2020 17:56
@codebytere codebytere force-pushed the pr-checker-jenkins-failures branch from 0ca7fc2 to b3796ec Compare May 22, 2020 18:11
@codecov
Copy link

codecov bot commented May 22, 2020

Codecov Report

Merging #422 into master will increase coverage by 0.79%.
The diff coverage is 80.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #422      +/-   ##
==========================================
+ Coverage   76.34%   77.13%   +0.79%     
==========================================
  Files          21       21              
  Lines        1484     1496      +12     
==========================================
+ Hits         1133     1154      +21     
+ Misses        351      342       -9     
Impacted Files Coverage Δ
lib/pr_checker.js 95.49% <80.00%> (-0.65%) ⬇️
lib/ci/ci_type_parser.js 81.25% <100.00%> (+0.29%) ⬆️
lib/ci/ci_result_parser.js 47.87% <0.00%> (+1.81%) ⬆️
lib/ci/ci_failure_parser.js 80.21% <0.00%> (+2.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f58051c...b3796ec. Read the comment docs.

@codebytere codebytere marked this pull request as ready for review May 22, 2020 18:13
@codebytere codebytere merged commit 75abd3a into nodejs:master May 26, 2020
@codebytere codebytere deleted the pr-checker-jenkins-failures branch May 26, 2020 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node land thinks a PR with failed build is landable
2 participants