Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node land thinks a PR with failed build is landable #377

Closed
sam-github opened this issue Nov 28, 2019 · 1 comment · Fixed by #422
Closed

node land thinks a PR with failed build is landable #377

sam-github opened this issue Nov 28, 2019 · 1 comment · Fixed by #422
Assignees

Comments

@sam-github
Copy link
Contributor

output from node-core-utils master here: nodejs/node#30637 (comment)

It correctly found the ci commit message, and the commit, but doesn't seem to evaluate its pass/fail status.

I tried again with npm install on 10.x, same issue:

core/lts (master $% u=) % git node land https://github.com/nodejs/node/pull/30637
✔  Done loading data for nodejs/node/pull/30637
----------------------------------- PR info ------------------------------------
Title      tls: expose IETF name for current cipher suite (#30637)
Author     Sam Roberts <[email protected]> (@sam-github)
Branch     sam-github:tls-standard-name -> nodejs:master
Labels     C++, crypto, semver-minor
Commits    1
 - tls: expose IETF name for current cipher suite
Committers 1
 - Sam Roberts <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/30637
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Yorkie Liu <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
--------------------------------------------------------------------------------
   ℹ  Last Full PR CI on 2019-11-27T23:21:35Z: https://ci.nodejs.org/job/node-test-pull-request/27056/
   ℹ  This PR was created on Mon, 25 Nov 2019 17:25:47 GMT
   ✔  Approvals: 8
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/30637#pullrequestreview-322484515
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/30637#pullrequestreview-322509526
   ✔  - David Carlier (@devnexen): https://github.com/nodejs/node/pull/30637#pullrequestreview-322823276
   ✔  - Yorkie Liu (@yorkie): https://github.com/nodejs/node/pull/30637#pullrequestreview-322831622
   ✔  - Ben Noordhuis (@bnoordhuis): https://github.com/nodejs/node/pull/30637#pullrequestreview-322868042
   ✔  - Anna Henningsen (@addaleax) (TSC): https://github.com/nodejs/node/pull/30637#pullrequestreview-322989675
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/30637#pullrequestreview-323816567
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/30637#pullrequestreview-323925693
--------------------------------------------------------------------------------
? This PR should be ready to land, do you want to continue? (Y/n)
@sam-github
Copy link
Contributor Author

I'll leave this in the current state in case anyone wants to look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants