Methods without corresponding tests #332

mhdawson · 2018-09-06T19:30:14Z

Need to document then list of methods that still need tests.

andrew-cc-chen · 2018-09-06T20:03:35Z

class	methods
Function	Function()
	Value Call(size_t argc, const napi_value* args) const
	Value Call(napi_value recv, size_t argc, const napi_value* args) const
	Value MakeCallback(napi_value recv, const std::initializer_list<napi_value>& args) const
	Value MakeCallback(napi_value recv, const std::vector<napi_value>& args) const
	Value MakeCallback(napi_value recv, size_t argc, const napi_value* args) const
	Object New(size_t argc, const napi_value* args) const
Object	Object()
	Object(napi_env env, napi_value value)
	PropertyLValuestd::string operator [](const char* utf8name)
	PropertyLValuestd::string operator [](const std::string& utf8name)
	PropertyLValue<uint32_t> operator [](uint32_t index)
	Value operator [](const char* utf8name) const
	Value operator [](const std::string& utf8name) const
	Value operator [](uint32_t index) const
	bool Has(uint32_t index) const
	Value Get(uint32_t index) const
	template void Set(uint32_t index, const ValueType& value)
	bool Delete(uint32_t index)
	void DefineProperties(const std::vector& properties)
	bool InstanceOf(const Function& constructor) const
Object::PropertyLValue	operator Value() const
	template PropertyLValue& operator =(ValueType value)
Number See PR #355	Number()
See PR #355	Number(napi_env env, napi_value value)
See PR #355	operator int32_t() const
See PR #355	operator uint32_t() const
See PR #355	operator int64_t() const
See PR #355	operator float() const
See PR #355	operator double() const
Value	Value(napi_env env, napi_value value)
	template static Value From(napi_env env, const T& value)
	operator napi_value() const
	bool operator ==(const Value& other) const
	bool operator !=(const Value& other) const
	bool StrictEquals(const Value& other) const
	Napi::Env Env() const
	bool IsEmpty() const
Boolean See PR #354	Boolean()
See PR #354	Boolean(napi_env env, napi_value value)
See PR #490	operator bool() const
See PR #354	bool Value() const
External	External()
	External(napi_env env, napi_value value)
Symbol	static Symbol New(napi_env env, const std::string& description)
	static Symbol New(napi_env env, napi_value description)
	Symbol()
	Symbol(napi_env env, napi_value value)
DataView	DataView()
	DataView(napi_env env, napi_value value)
	void* Data() const
Array	static Array New(napi_env env, size_t length)
	Array()
	Array(napi_env env, napi_value value)
	uint32_t Length() const
ArrayBuffer	ArrayBuffer(napi_env env, napi_value value)
TypedArray	TypedArray()
	TypedArray(napi_env env, napi_value value)
	uint8_t ElementSize() const
	size_t ByteOffset() const
	size_t ByteLength() const
	TypedArray(napi_env env, napi_value value, napi_typedarray_type type, size_t length)
	napi_typedarray_type TypedArrayTypeForPrimitiveType()
TypedArrayOf	TypedArrayOf()
	TypedArrayOf(napi_env env, napi_value value)
	T& operator [](size_t index)
	const T& operator [](size_t index) const
	T* Data()
	const T* Data() const
Error	static Error New(napi_env env)
	Error()
	Error(napi_env env, napi_value value)
	Error(Error&& other)
	Error& operator =(Error&& other)
	Error(const Error&)
	Error& operator =(Error&)
	const char* what() const NAPI_NOEXCEPT override
	typedef napi_status (create_error_fn)(napi_env envb, napi_value code, napi_value msg, napi_value result)
	template static TError New(napi_env env, const char* message, size_t length, create_error_fn create_error)
TypeError	static TypeError New(napi_env env, const char* message)
	TypeError()
	TypeError(napi_env env, napi_value value)
RangeError	static RangeError New(napi_env env, const char* message)
	RangeError()
	RangeError(napi_env env, napi_value value)
Buffer	Buffer()
	Buffer(napi_env env, napi_value value)
String	static String New(napi_env env, const std::u16string& value)
	template static String From(napi_env env, const T& value)
	String()
	String(napi_env env, napi_value value)
	operator std::string() const
	operator std::u16string() const
PropertyDescriptor	static PropertyDescriptor Accessor(napi_value name, Getter getter, ......)
	static PropertyDescriptor Accessor(napi_value name, Getter getter, Setter setter, ......)
	static PropertyDescriptor Function(napi_value name, Callable cb, ......)
	static PropertyDescriptor Value(napi_value name, napi_value value, napi_property_attributes attributes = napi_default)
	PropertyDescriptor(napi_property_descriptor desc)
	operator napi_property_descriptor&()
	operator const napi_property_descriptor&() const
ClassPropertyDescriptor	ClassPropertyDescriptor(napi_property_descriptor desc)
	operator napi_property_descriptor&()
	operator const napi_property_descriptor&() const
AsyncWorker	AsyncWorker(AsyncWorker&& other)
	AsyncWorker& operator =(AsyncWorker&& other)
	AsyncWorker(const AsyncWorker&)
	AsyncWorker& operator =(AsyncWorker&)
	operator napi_async_work() const
	Napi::Env Env() const
	void Cancel()
	FunctionReference& Callback()
	explicit AsyncWorker(const Function& callback)
	explicit AsyncWorker(const Function& callback, const char* resource_name)
	explicit AsyncWorker(const Object& receiver, const Function& callback)
	explicit AsyncWorker(const Object& receiver, const Function& callback, const char* resource_name)
	explicit AsyncWorker(const Object& receiver, const Function& callback, const char* resource_name, const Object& resource)
	virtual void Execute()
	virtual void OnOK()
	virtual void OnError(const Error& e)
Reference	Reference()
	Reference(napi_env env, napi_ref ref)
	Reference(Reference&& other)
	Reference& operator =(Reference&& other)
	Reference& operator =(Reference&)
	operator napi_ref() const
	bool operator ==(const Reference &other) const
	bool operator !=(const Reference &other) const
	Napi::Env Env() const
	void Reset()
	void Reset(const T& value, uint32_t refcount = 0)
	Reference(const Reference&)
ObjectReference	ObjectReference()
	ObjectReference(napi_env env, napi_ref ref)
	ObjectReference(Reference&& other)
	ObjectReference& operator =(Reference&& other)
	ObjectReference(ObjectReference&& other)
	ObjectReference& operator =(ObjectReference&& other)
	ObjectReference& operator =(ObjectReference&)
	Napi::Value Get(const std::string& utf8name) const
	void Set(const char* utf8name, napi_value value)
	void Set(const char* utf8name, double numberValue)
	void Set(const std::string& utf8name, napi_value value)
	void Set(const std::string& utf8name, Napi::Value value)
	void Set(const std::string& utf8name, std::string& utf8value)
	void Set(const std::string& utf8name, bool boolValue)
	void Set(const std::string& utf8name, double numberValue)
	void Set(uint32_t index, const napi_value value)
	void Set(uint32_t index, const Napi::Value value)
	void Set(uint32_t index, const std::string& utf8value)
	void Set(uint32_t index, bool boolValue)
	void Set(uint32_t index, double numberValue)
	ObjectReference(const ObjectReference&)
FunctionReference	FunctionReference(napi_env env, napi_ref ref)
	FunctionReference(Reference&& other)
	FunctionReference& operator =(Reference&& other)
	FunctionReference(FunctionReference&& other)
	FunctionReference& operator =(FunctionReference&& other)
	FunctionReference(const FunctionReference&) = delete
	FunctionReference& operator =(FunctionReference&) = delete
	Napi::Value Call(const std::initializer_list<napi_value>& args) const
	Napi::Value Call(const std::vector<napi_value>& args) const
	Napi::Value Call(napi_value recv, const std::initializer_list<napi_value>& args) const
	Napi::Value Call(napi_value recv, const std::vector<napi_value>& args) const
	Napi::Value MakeCallback(napi_value recv, const std::initializer_list<napi_value>& args) const
	Napi::Value MakeCallback(napi_value recv, const std::vector<napi_value>& args) const
	Object New(const std::vector<napi_value>& args) const
HandleScope	HandleScope(napi_env env, napi_handle_scope scope)
	operator napi_handle_scope() const
	Napi::Env Env() const
EscapableHandleScope	operator napi_escapable_handle_scope() const
	Napi::Env Env() const
	Value Escape(napi_value escapee)
ObjectWrap	static T* Unwrap(Object wrapper)
	typedef void (*StaticVoidMethodCallback)(const CallbackInfo& info)
	typedef Napi::Value (*StaticMethodCallback)(const CallbackInfo& info)
	typedef Napi::Value (*StaticGetterCallback)(const CallbackInfo& info)
	typedef void (*StaticSetterCallback)(const CallbackInfo& info, const Napi::Value& value)
	typedef void (T::*InstanceVoidMethodCallback)(const CallbackInfo& info)
	typedef Napi::Value (T::*InstanceMethodCallback)(const CallbackInfo& info)
	typedef Napi::Value (T::*InstanceGetterCallback)(const CallbackInfo& info)
	typedef void (T::*InstanceSetterCallback)(const CallbackInfo& info, const Napi::Value& value)
	typedef ClassPropertyDescriptor PropertyDescriptor
	static Function DefineClass(Napi::Env env, const char* utf8name, const std::vector& properties, ......)
	static PropertyDescriptor StaticMethod(const char* utf8name, StaticVoidMethodCallback method, ......)
	static PropertyDescriptor StaticMethod(const char* utf8name, StaticMethodCallback method, ......)
	static PropertyDescriptor StaticAccessor(const char* utf8name, StaticGetterCallback getter, StaticSetterCallback setter, ......)
	static PropertyDescriptor InstanceMethod(Symbol name, InstanceVoidMethodCallback method, ......)
	static PropertyDescriptor StaticValue(const char* utf8name, Napi::Value value, ......)
	static PropertyDescriptor InstanceValue(const char* utf8name, Napi::Value value, ......)
Promise::Deferred	Deferred(napi_env env)
CallbackInfo	CallbackInfo(napi_env env, napi_callback_info info)
	CallbackInfo(CallbackInfo const &)
	void operator=(CallbackInfo const &)
	Value NewTarget() const
	size_t Length() const
	const Value operator [](size_t index) const
	Value This() const
	void SetData(void* data)
Env	Env(napi_env env)
	operator napi_env() const
	Object Global() const
	Value Undefined() const
	Value Null() const
global	template Reference Weak(T value)
	FunctionReference Weak(Function value)
	template Reference Persistent(T value)

mhdawson · 2018-09-26T22:14:17Z

From work that @andrew-cc-chen has done, this looks like the current coverage:

node-addon-api-coverage.pdf

Its not as good as the html view in that it does not show the function name being covered.

I would like to write tests fro array class. ISSUE=nodejs#332

NickNaso · 2019-08-26T17:24:18Z

Hi everybody,
I'm working on two PRs to add test for Napi::Value and Napi::String.

github-actions · 2021-03-08T01:01:24Z

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

JoseExposito · 2021-03-10T07:53:51Z

I submitted a couple of PRs adding missing test for Object and Function.

NickNaso · 2021-03-12T19:40:28Z

I submitted a couple of PRs adding missing test for Object and Function.

The PRs are #923 and #928

jschlight · 2021-03-16T00:39:25Z

@mhdawson Jack needs to be able to update the table in the comment above for the work he's doing for the project.

I think it makes sense to transfer the table into a test-coverage.md file that's stored in the repository so that changes can be made and tracked using PRs. A couple of questions:

Does it make sense to create a test-coverage.md file?
Where's the best place to put the file? It could be the project root, doc, or test.

I'm happy to make whatever change we decide on.

If we decide to keep it simple and continue to maintain the information on the table above, Jack will need write access to this issue.

@JckXia

NickNaso · 2021-03-16T10:33:52Z

Hi @jschlight,
I think that could be more appropriate create separate issues for every class item in the table es. global env and track all the work in those issues.
In terms of documentation we need to add a guid on how to add a new test case.
About the coverage we should use some tools to create a report for the coverage.

mhdawson · 2021-03-16T15:40:21Z

@NickNaso suggestion will address the issue. As the originator of the new issues Jack will be able to edit them as well. So maybe close the existing one and he can open a new set of issues to cover the work.

JckXia · 2021-03-16T16:03:47Z

Okay thanks everyone, just to make sure, would I need open a new issue per each class (i.e separate issues for Objects, Functions, Buffer, String etc?) I'm just wondering if it will clog up the issue tracker as there exists around 20+ classes.

NickNaso · 2021-03-16T16:10:38Z

Hi @JckXia,
I think you can proceed. My advice is to tag the issue you created with the test tag. If you cannot able to do that I can do it for you after you crated the issue.

JckXia · 2021-03-16T16:19:32Z

@NickNaso Okay thank you! Yeah it looks like I can't tag the issues. Will create the set of issues after work today.

github-actions · 2021-06-15T00:12:03Z

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

github-actions · 2021-09-15T00:11:02Z

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

mhdawson · 2021-09-16T13:32:33Z

@JckXia do we still need this issue or is it replace by the other issues you created? If yes then I'll close this issue.

JckXia · 2021-09-16T13:35:06Z

Hey @mhdawson , I think we can close this issue.

mhdawson · 2021-09-16T13:40:41Z

@JckXia thanks for the quick response.

mhdawson mentioned this issue Sep 6, 2018

Create matrix of tested methods. nodejs/abi-stable-node#337

Closed

NickNaso mentioned this issue Sep 7, 2018

Comprehensive node-addon-api test suite #163

Closed

33 tasks

NickNaso mentioned this issue Sep 24, 2018

Some updates on Boolean documentation and added 5 new test case #354

Closed

nadongguri mentioned this issue Sep 25, 2018

tests: add operator overloading tests for Number class #355

Closed

NickNaso added the test label Sep 27, 2018

yjaeseok added a commit to yjaeseok/node-addon-api that referenced this issue Oct 2, 2018

Write tests for Array class

9cd5222

I would like to write tests fro array class. ISSUE=nodejs#332

yjaeseok added a commit to yjaeseok/node-addon-api that referenced this issue Oct 2, 2018

Write tests for Array class

cc6a9b9

I would like to write tests fro array class. ISSUE=nodejs#332

yjaeseok mentioned this issue Oct 2, 2018

Write tests for Array class #363

Closed

nadongguri mentioned this issue Oct 16, 2018

test: add arraybuffer tests #369

Closed

NickNaso mentioned this issue Jun 10, 2019

test: Added test for bool operator #490

Closed

This was referenced Sep 30, 2019

Propose code and learn session for node-addon-api testing nodejs/abi-stable-node#385

Closed

Session Topic: node-addon-api - test for success openjs-foundation/code-and-learn#5

Open

mhdawson added the good first issue label Dec 7, 2020

JoseExposito mentioned this issue Mar 6, 2021

Add Object missing tests #923

Closed

github-actions bot added the stale label Mar 8, 2021

mhdawson removed the stale label Mar 12, 2021

github-actions bot added the stale label Jun 15, 2021

mhdawson removed the stale label Jun 16, 2021

github-actions bot added the stale label Sep 15, 2021

mhdawson closed this as completed Sep 16, 2021

nodejs deleted a comment from lam19892089 Nov 6, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Methods without corresponding tests #332

Methods without corresponding tests #332

mhdawson commented Sep 6, 2018

andrew-cc-chen commented Sep 6, 2018 •

edited by NickNaso

Loading

mhdawson commented Sep 26, 2018 •

edited

Loading

NickNaso commented Aug 26, 2019

github-actions bot commented Mar 8, 2021

JoseExposito commented Mar 10, 2021

NickNaso commented Mar 12, 2021

jschlight commented Mar 16, 2021

NickNaso commented Mar 16, 2021

mhdawson commented Mar 16, 2021

JckXia commented Mar 16, 2021

NickNaso commented Mar 16, 2021

JckXia commented Mar 16, 2021

github-actions bot commented Jun 15, 2021

github-actions bot commented Sep 15, 2021

mhdawson commented Sep 16, 2021

JckXia commented Sep 16, 2021

mhdawson commented Sep 16, 2021

Methods without corresponding tests #332

Methods without corresponding tests #332

Comments

mhdawson commented Sep 6, 2018

andrew-cc-chen commented Sep 6, 2018 • edited by NickNaso Loading

mhdawson commented Sep 26, 2018 • edited Loading

NickNaso commented Aug 26, 2019

github-actions bot commented Mar 8, 2021

JoseExposito commented Mar 10, 2021

NickNaso commented Mar 12, 2021

jschlight commented Mar 16, 2021

NickNaso commented Mar 16, 2021

mhdawson commented Mar 16, 2021

JckXia commented Mar 16, 2021

NickNaso commented Mar 16, 2021

JckXia commented Mar 16, 2021

github-actions bot commented Jun 15, 2021

github-actions bot commented Sep 15, 2021

mhdawson commented Sep 16, 2021

JckXia commented Sep 16, 2021

mhdawson commented Sep 16, 2021

andrew-cc-chen commented Sep 6, 2018 •

edited by NickNaso

Loading

mhdawson commented Sep 26, 2018 •

edited

Loading