Function tests

[JoseExposito]

This PR adds tests for every Function method.

I splitted the changes in commits so the diff is easier to follow.

EDIT 🤔

All tests passed!
Tests aborted with SIGSEGV

[mhdawson]

@JoseExposito thanks for working on this.

I see in your output:

All tests passed!
Tests aborted with SIGSEGV

Do you see that every time? It indicates something is not quite right so wondering if its related to the PR or possibly an existing intermittent issue.

[JoseExposito]

Hi @mhdawson

I don't have permissions to re-run the failed jobs upstream, however, in my fork, they finished successfully:
https://github.com/JoseExposito/node-addon-api/actions/runs/638531308

My guess is that it is an intermittent crash on macOS. I'm going to merge main, let's see what happens...

[JoseExposito]

It worked 🎉 It looks like an intermittent issue, none of the runs on my fork failed:
https://github.com/JoseExposito/node-addon-api/actions

[NickNaso]

@JoseExposito thanks for adding this test cases. Just some comments.

[NickNaso]

LGTM.

[mhdawson]

LGTM

[mhdawson]

I merged this but I found that the tests were failing after having done that with this output on 14.x

Running test 'object/finalizer'
(node:1257166) UnhandledPromiseRejectionWarning: AssertionError [ERR_ASSERTION]: function should not have been called
at mustNotCall (/home/midawson/newpull/land/node-addon-api/test/common/index.js:74:12)
(Use node --trace-warnings ... to show where the warning was created)
(node:1257166) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag --unhandled-rejections=strict (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:1257166) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

and this output on 16.x

Running test 'object/finalizer'
node:internal/process/promises:227
          triggerUncaughtException(err, true /* fromPromise */);
          ^

AssertionError [ERR_ASSERTION]: function should not have been called
    at mustNotCall (/home/midawson/newpull/land/node-addon-api/test/common/index.js:74:12) {
  generatedMessage: false,
  code: 'ERR_ASSERTION',
  actual: undefined,
  expected: undefined,
  operator: 'fail'
}

So I've reverted it. Since it's in a different test it must be some interaction between the tests.

[mhdawson]

@JoseExposito could you take a look and then submit and updated PR?

[JoseExposito]

Good catch @mhdawson , I overlooked that log. I created a new PR (#937) fixing the issue.