Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: add operator overloading tests for Number class #355

Closed
wants to merge 3 commits into from
Closed

tests: add operator overloading tests for Number class #355

wants to merge 3 commits into from

Conversation

nadongguri
Copy link
Contributor

@nadongguri nadongguri commented Sep 25, 2018 •
edited
Loading

Hi node-addon-api members,

in this PR, I added tests for checking operator overloading for Number class.

class methods
Number operator int32_t() const
  operator uint32_t() const
  operator int64_t() const
  operator float() const
  operator double() const

Please review and suggest some other test cases. See the issue #332.

@NickNaso
Copy link
Member

Hi @nadongguri,
I just taken a look at your tests and they seem good. Maybe you can add the following test:

  • Empty Napi::Number using Napi::Number() in this case you can use the method Napi::Value::IsEmpty() to check the object you created is empty or not.

  • Create a new Napi::Number object from another using constructor that take as parameters napi_env and napi_value (Napi::Number(napi_env env, napi_value value)). Maybe you can pass a Number to a function and create a new Napi::Number then return it to JavaScript and check if it is equal or not to your initial value.

Hope you agree with my proposal. Keep me updated. Thanks for your contribution.

@nadongguri
Copy link
Contributor Author

Hi @NickNaso,
thanks for your comment. I'll surely add those tests.

@nadongguri
Copy link
Contributor Author

Hi @NickNaso,
I added these tests based on your guide. :)

class methods
Number Number()
  Number(napi_env env, napi_value value)

mhdawson
mhdawson approved these changes Sep 27, 2018
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

NickNaso
NickNaso approved these changes Sep 27, 2018
View reviewed changes
Copy link
Member

@NickNaso NickNaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @nadongguri Good work!

mhdawson pushed a commit that referenced this pull request Sep 28, 2018
@mhdawson
test: add operator overloading tests in Number
779560f 
PR-URL: #355
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Nicola Del Gobbo <[email protected]>
@mhdawson
Copy link
Member

landed as 779560f. Thanks @nadongguri

@mhdawson mhdawson closed this Sep 28, 2018
yjaeseok pushed a commit to yjaeseok/node-addon-api that referenced this pull request Oct 1, 2018
@yjaeseok
test: add operator overloading tests in Number
cbddd6b 
PR-URL: nodejs#355
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Nicola Del Gobbo <[email protected]>
@andrew-cc-chen andrew-cc-chen mentioned this pull request Dec 20, 2018
Closed
@JckXia JckXia mentioned this pull request Mar 21, 2021
Closed
kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this pull request Aug 24, 2022
@kevindavies8
test: add operator overloading tests in Number
de8c29d 
PR-URL: nodejs/node-addon-api#355
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Nicola Del Gobbo <[email protected]>
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this pull request Aug 26, 2022
@Marlyfleitas
test: add operator overloading tests in Number
315245a 
PR-URL: nodejs/node-addon-api#355
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Nicola Del Gobbo <[email protected]>
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this pull request Sep 19, 2022
@wroy7860
test: add operator overloading tests in Number
89821ca 
PR-URL: nodejs/node-addon-api#355
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Nicola Del Gobbo <[email protected]>
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this pull request Aug 11, 2023
test: add operator overloading tests in Number
497492b 
PR-URL: nodejs/node-addon-api#355
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Nicola Del Gobbo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@NickNaso NickNaso NickNaso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nadongguri @NickNaso @mhdawson