-
-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.0.0 #178
3.0.0 #178
Conversation
required for some emoji to be displayed as pictograph
Nice! ⚡ |
Do I understand correctly that the new version will export a hash like?:
Is there an ETA on this work? |
any news? Looking forward for this release 😀 |
Wondering what's blocking this? |
My burnout state of mind unfortunately. :)
Looks like this is where I left it: emojilib/dist/emoji-en-US.json Lines 2 to 10 in e3b4c85
Looking back now though I can see how this is not desirable for existing consumers of this library, as they would need to pull in an alternate source for other emoji metadata (hence the MAJOR version bump). IIRC, I made this decision because people often request features like "shortcode used for <github/discord/slack/etc> service", which I consider out of the scope of this project. To work around this they'd have to pull in other libraries that do this. This seems tedious, but given that the emoji dataset is gigantic and will only grow in the future, I feel like this is for the best. I know there are the swiss army knife type of emoji data libraries out there. An ideal scenario would be that they pull this dataset in instead. I'd personally love to see a emoji module that let you build your own dataset.
Maybe this already exist, I don't know. But this is more than what I feel comfortable taking on. So once this is merged, I imagine that I'll be doing something like this for my own use cases: const emojiData = require('unicode-emoji-json') // https://github.com/muan/unicode-emoji-json/blob/master/data-by-emoji.json
const keywordData = require('emojilib') // needs a better name to clarify purpose
for (const emoji in emojiData) { // 😀
const keywords = keywordData[emoji] // ["grinning_face","face","smile","happy","joy",":D","grin"]
return html`<button data-keywords="${keywords.join(' ')}">${emoji} ${emojiData[emoji]['name']}</button>`
} Any thoughts? |
@muan I think your approach is the right one. I came to it naturally as well when I investigated the travesty that is this spec (https://twitter.com/jsumners79/status/1211105577188970497). Like you, I haven't had the time or constitution to get back to it. But my idea was to write a tool that will read all of the base spec files and mash them into something usable. |
👍
|
I think I was using CLDR to include skin tone variations. |
This makes sense, and it's already what I'm doing. I also saw that Emoji Mart is doing the same. A good source for normal emoji metadata (no keywords) we both used is |
Apologies for the delay. Here's the new dataset. |
I plan to introduce a few breaking changes to emojilib in order to contain the scope of this project. In short, this project should only be adding keywords to emoji, and nothing more. This means:
muan/unicode-emoji-json
, instead of manually added here. (Updating list #125, Idea: List Unicode version for each emoji #126)simplemap.json
andordered.json
will be removed, since they have nothing to do with emoji keywords. They can be generated frommuan/unicode-emoji-json
if people want it.main
to JSON instead of a node interface.TODO:
cc @jasonrudolph FYI