-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add many missing emoji aliases #41
Conversation
ed183f4
to
e8fa3b4
Compare
Hi @gencer ! Thanks for the PR 🔥 Looks like most of them are duplicates of existing aliases with a different name (which is fine of course). It's pretty hard for me to identify in such a big list if there is any new emoji (which is what adds the most value). Are there any ? Also, could you please tell us the source of data you used and include the script you used to retrieve the data ? We currently have a script that already automatise this process for us, let's see how we can improve it. |
Hi @enzoferey! Glad you liked the PR.
To be honest, I am not specifically sure. But i can filter and separately append new emojis at last and separate with comment if you like.
I never saw your script before until you mentioned here, actually. However, I made a silly dummy ruby script that loads 3 different emoji JSON list and then iterate all and unique by name at last. EmojiOne also uses description as an alias. They replace spaces with underscore and exclude anything that contains Please note that. I use draft-js-emoji-plugin which uses EmojiOne v2. When I insert emojis to editor and then render in body, i got many of them not rendered due to unknown emoji aliases. With my additions, all of my aliases properly rendered. Here is ruby script responsible of alias mapping. (As i said its very silly and dummy script with no consciousness.) In fact not the emojione responsible for aliases, but unicode representatives are responsible and those aliases exists. |
Hello again @gencer ! Sorry for the delay. Thanks for the sources. Is there any reason why you use the We would love to solve this emojis source issues once for all and be able to update them automatically whenever new ones come out, but we need to be very picky about the sources in order to ensure we won't be missing any of them and we will be using the right aliases. I keep your sources as a reference and I hope to be able to spend some time in the next few days doing some research about the topic. Any help would be greatly appreciated 👍 |
Hi there ! Summary of my research: I found out about https://github.com/muan/unicode-emoji-json. It has been just started by the creator of https://github.com/muan/emojilib as a way to scrap the official Unicode documents. It looks pretty solid. The issue is in term of the aliases. Aliases has been made up by the community over time and nowadays there are many inconsistencies between emoji libraries (for example muan/emojilib#135). As pointed out here, it looks like It looks like https://github.com/github/gemoji/blob/master/db/emoji.json is the best shot out there (seems like @gencer took some inspiration from them for the script). They are parsing the official docs as What I'm suggesting to do is:
// data/aliases/baseAliases.json
{
"😀": ["grinning_face"],
...
}
// data/aliases/gemojiAliases.json
{
"😀": ["grinning_face", "smile"],
...
}
// data/aliases/customAliases.json
{
"😀": ["custom_alias_1", "custom_alias_2"],
...
}
// data/aliases.js
module.exports = {
"grinning_face": "😀",
"smile": "😀",
"custom_alias_1": "😀",
"custom_alias_2": "😀",
... This setup allows us to:
Waiting for your feedback guys. cc @tommoor. |
LGTM. As you said, with this scheme we will have latest changes available always. |
@enzoferey reading through the conversation I think it's a good idea have this flow update. |
Hi @abnersajr ! Creating the other PR would take a just a couple of hours, thus merging this PR wouldn’t bring much value in my opinion. But I’m not against 👍🏻 The problem is that @tommoor is not coming around here very frequently and I don’t have rights to merge pull requests and even less publish new versions of the library. That’s why I ask about specs before opening the PR. I don’t want to spend a couple of hours for not getting anything merged in months. |
@enzoferey yep – I think the idea is great here. Unfortunately this repo is not at the top of all of my OSS repos in terms of priority so it doesn't get as much attention. As such, I've made you a collaborator @enzoferey so you can push this forward as you see fit. |
Thanks for the trust @tommoor. I will work along the weekend to close this PR @gencer @abnersajr 👍 |
Merging this into the branch where I will implement the pipeline defined at #41 (comment) in order to start with the maximum amount of aliases in our Thanks @gencer 👍 |
I've added many missing aliases to support rendering more emojis especially via emojione. But it contains from several sources. I did this via script so no duplicates (as for aliases).