Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating list #125

Closed
jjaffeux opened this issue Jun 15, 2017 · 2 comments
Closed

Updating list #125

jjaffeux opened this issue Jun 15, 2017 · 2 comments

Comments

@jjaffeux
Copy link

Hello,

we are using your list at Discourse: https://github.com/discourse/discourse/blob/master/lib/tasks/emoji.rake

Thanks for it!

However, we sometimes have to patch it (code, Fitzpatrick scale...). What kind of PR are you willing to merge? Anything that would match with http://unicode.org/emoji/charts/emoji-list.html ?

For example running_woman is noted as "fitzpatrick_scale": false while it should be true (http://unicode.org/emoji/charts/emoji-list.html#1f3c3_1f3fb_200d_2640_fe0f).

@muan
Copy link
Owner

muan commented Jul 6, 2017

we are using your list at Discourse: https://github.com/discourse/discourse/blob/master/lib/tasks/emoji.rake

Awesome!

Anything that would match with http://unicode.org/emoji/charts/emoji-list.html ?

Definitely this. Basically if it doesn't match unicode's emoji list then our data is wrong. :) Please contribute ❤️. Those fitzpatrick_scale were done manually so are prone to error for sure.

@jjaffeux
Copy link
Author

jjaffeux commented Jul 6, 2017

Hi @muan,

in the meantime I've created: https://github.com/jjaffeux/emoji-db
https://github.com/jjaffeux/emoji-db/blob/master/generated/db.json

category and fitzpatrick_scale are automatically generated.

@muan muan mentioned this issue Oct 13, 2019
2 tasks
@muan muan closed this as completed Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants