-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Puppeteer E2E test: Regenerate high-differenсe screenshots and decrease threshold #25403
Puppeteer E2E test: Regenerate high-differenсe screenshots and decrease threshold #25403
Conversation
Not sure what is the noise in webgl_camera... Remaining high differences (most are due to different text font on Windows vs Linux):
|
test/e2e/puppeteer.js
Outdated
'webxr_ar_lighting', // webxr | ||
|
||
'webgl_worker_offscreencanvas', // in a worker, not robust | ||
|
||
// Windows-Linux text rendering differences | ||
// TODO: Fix these by setting a font in Puppeteer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will try to fix these in a separate PR.
'webgl_shaders_tonemapping', | ||
'webgpu_nodes_playground', | ||
|
||
// Unknown | ||
// TODO: most of these can be fixed just by increasing idleTime and parseTime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same with these.
test/e2e/puppeteer.js
Outdated
@@ -59,7 +76,7 @@ const chromiumChannel = 'stable'; // stable -> beta -> dev -> canary (Mac and Wi | |||
|
|||
const port = 1234; | |||
const pixelThreshold = 0.1; // threshold error in one pixel | |||
const maxFailedPixels = 0.05; // at most 5% failed pixels | |||
const maxFailedPixels = 0.3; // at most 0.3% failed pixels |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.3% or 3%?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.3% -- more than 10x decrease.
Related issue: #24109
Description
Regenerate screenshots that produce at least 0.3% difference on at least one platform:
Generated using Chromium 109.0.5414.120 (revision 1070054, https://storage.googleapis.com/chromium-browser-snapshots/Win_x64/1070054/chrome-win.zip), stable channel on win64.