-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Puppeteer E2E test: Multi-page in-browser parallelism #25386
Puppeteer E2E test: Multi-page in-browser parallelism #25386
Conversation
Strange that tests fail... Seems like a page is used simultaneously in two attempts (but that should be impossible because of the lock)?..
|
Especially strange that I don't see that problem when running locally... |
Seems like the Mac problems are related to puppeteer/puppeteer#8693... I will investigate more. |
* Puppeteer: Bug fix * Disable MacOS until a proper solution in #25386
Headful: |
Hm... Even with multiple browsers instead of multiple pages TimeoutError happens. So maybe it is not puppeteer/puppeteer#8693... |
It could be fixed just by increasing networkTimeout 🤦♂️ I think it works now. (I will re-run the tests a few times more just to check) |
Seems that it works! |
Seems like sometimes Mac fails even with a large timeout... |
@mrdoob I think we can merge this PR and possibly tweak the number of CI threads, browser pages, and network timeout later. (It should work currently) |
Will run tests a few times to see if some examples don't work under new threshold... |
@mrdoob Seems to work! |
Related issue: #24109
Description
Add multi-page parallelism to Puppeteer and also decrease CI parallelism to 4 threads.