Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: Fixed NodeMaterial not import error. #25400

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

linbingquan
Copy link
Contributor

Related commit: 3f0b691

Description

As the title.

Error info:

webgl_nodes_loader_gltf_sheen.html:71 
        
       Uncaught (in promise) ReferenceError: NodeMaterial is not defined
    at webgl_nodes_loader_gltf_sheen.html:71:24
    at GLTFLoader.js:220:6
    at GLTFLoader.js:2461:5

@Mugen87 Mugen87 added this to the r150 milestone Feb 1, 2023
@Mugen87 Mugen87 merged commit aeb4444 into mrdoob:dev Feb 1, 2023
@mrdoob
Copy link
Owner

mrdoob commented Feb 2, 2023

Hmm, shouldn't have the CI failed? 🤔

@linbingquan
Copy link
Contributor Author

linbingquan commented Feb 2, 2023

Hmm, shouldn't have the CI failed? 🤔

That's an interesting question.

https://github.com/mrdoob/three.js/actions/runs/4061863540/jobs/6992289842#step:6:42

Diff 4.7% in file: webgl_nodes_loader_gltf_sheen

@mrdoob
Copy link
Owner

mrdoob commented Feb 2, 2023

/ping @LeviPesin

@LeviPesin
Copy link
Contributor

5% is just a too large threshold -- I was able to decrease it to 0.3% in #25403.

@linbingquan linbingquan deleted the dev-example-sheen branch August 19, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants