GLTFLoader: Clean up Skeleton binding
#25033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donmccurdy
reviewed
Nov 29, 2022
takahirox
commented
Nov 29, 2022
takahirox
force-pushed
the
GLTFLoaderCleanupSkeletonBinding
branch
from
c20b568 to
cb12fa7
Compare
takahirox
force-pushed
the
GLTFLoaderCleanupSkeletonBinding
branch
from
cb12fa7 to
0a90d23
Compare
donmccurdy
approved these changes
Nov 30, 2022
takahirox
added a commit
to Hubs-Foundation/three.js
that referenced
this pull request
Dec 7, 2022
[HUBS] This change is needed for glTF LOD support. This commit will be in r148. We can remove this commit when upgrading our Three.js fork to r148 or newer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second PR for
GLTFLoaderloadSkin/Node()clean up PR series following #25007Description
This PR cleans up
SkinnedMeshSkeletonbinding. I think doing it inloadNode()is more intuitive than doing inbuildNodeHierarchy()./cc @donmccurdy