GLTFLoader: Clean up loadSkin().
#25007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takahirox
commented
Nov 23, 2022
takahirox
commented
Nov 23, 2022
takahirox
force-pushed
the
GLTFLoaderCleanupLoadSkin
branch
from
c994a28 to
b8fa31d
Compare
Mugen87
approved these changes
Nov 24, 2022
Mugen87
changed the title
loadSkin().
donmccurdy
reviewed
Nov 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have some ideas to clean up
loadSkin()andloadNode()inGLTFLoader(GLTFParser). I want to break it up into some PRs for easier review. This is the first PR of them.This PR cleans up
loadSkin()by moving the skeleton build processing intoloadSkin()and lettingloadSkin()returnSkeletoninstance. I think it is more intuitive./cc @donmccurdy