Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPU: Fixes #23003

Merged
merged 3 commits into from
Dec 11, 2021
Merged

WebGPU: Fixes #23003

merged 3 commits into from
Dec 11, 2021

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Dec 11, 2021

Related issue: #22901 (comment)

Description

  • WGSL: deprecated attribute: [[ block ]]
  • fix alpha(vec4) used in material.colorNode
  • fix non-float used in material.roughnessNode

This contribution is funded by Google via Igalia.

warning: use of deprecated language feature: [[block]] attributes have been removed from WGSL [[ block ]]
@mrdoob mrdoob added this to the r136 milestone Dec 11, 2021
@mrdoob mrdoob merged commit b31270c into mrdoob:dev Dec 11, 2021
@mrdoob
Copy link
Owner

mrdoob commented Dec 11, 2021

Thanks!

gero3 pushed a commit to gero3/three.js that referenced this pull request Dec 13, 2021
* WGSL: deprecated attribute: [[ block ]]

warning: use of deprecated language feature: [[block]] attributes have been removed from WGSL [[ block ]]

* fix alpha used in color

* fix non-float roughness
gero3 pushed a commit to gero3/three.js that referenced this pull request Dec 14, 2021
* WGSL: deprecated attribute: [[ block ]]

warning: use of deprecated language feature: [[block]] attributes have been removed from WGSL [[ block ]]

* fix alpha used in color

* fix non-float roughness
gero3 pushed a commit to gero3/three.js that referenced this pull request Dec 16, 2021
* WGSL: deprecated attribute: [[ block ]]

warning: use of deprecated language feature: [[block]] attributes have been removed from WGSL [[ block ]]

* fix alpha used in color

* fix non-float roughness
@sunag sunag deleted the dev-webgpu-fixes branch January 27, 2022 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants