Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPU: Fixes (2) #23005

Merged
merged 2 commits into from
Dec 12, 2021
Merged

WebGPU: Fixes (2) #23005

merged 2 commits into from
Dec 12, 2021

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Dec 12, 2021

Related issue: #23003

Description

  • Use a regular direction vector in Dot Product in NodeEditor Rim example:
    • MacOS does not match renderer with Windows if used values greater than 1.0
  • fix min/max WebGPU if used: max( vec(), float() )

This contribution is funded by Google via Igalia.

@mrdoob mrdoob added this to the r136 milestone Dec 12, 2021
@mrdoob mrdoob merged commit 213a50c into mrdoob:dev Dec 12, 2021
@mrdoob
Copy link
Owner

mrdoob commented Dec 12, 2021

Thanks!

gero3 pushed a commit to gero3/three.js that referenced this pull request Dec 13, 2021
* fix min/max webgpu if used: max( vec(), float() )

* Regular direction of Dot Product
gero3 pushed a commit to gero3/three.js that referenced this pull request Dec 14, 2021
* fix min/max webgpu if used: max( vec(), float() )

* Regular direction of Dot Product
gero3 pushed a commit to gero3/three.js that referenced this pull request Dec 16, 2021
* fix min/max webgpu if used: max( vec(), float() )

* Regular direction of Dot Product
@sunag sunag deleted the dev-webgpu-fixes3 branch January 27, 2022 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants