Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeMaterial: Playground ( WebGPU version ) #22901

Merged
merged 17 commits into from
Nov 29, 2021
Merged

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Nov 28, 2021

Related issue: #22868

Description

https://raw.githack.com/sunag/three.js/dev-scene-apply/examples/?q=playground#webgl_materials_nodes_playground

image

  • add material.dispose() support to WebGPU ( c00e1a3 ) /ping: @Mugen87
  • add outputEncoding ( sRGBEncoding ) support to WebGPU
  • add bvec3 support to WebGPU
  • ColorSpaceNode: Add support to LinearTosRGB
  • Update origin-trial token (threejs.org)
  • Create PhysicalMaterialFunctions for some PBR functions ( a8cb423 )
  • ShaderNode: add normalGeometry
  • add lessThanEqual function for WebGPU
  • Minor fixes

This contribution is funded by Google via Igalia.

@Mugen87
Copy link
Collaborator

Mugen87 commented Nov 28, 2021

add material.dispose() support to WebGPU ( c00e1a3 )

The support for Material.dispose() was already implemented. Do you mind explaining in more detail your changes in that context?

@sunag
Copy link
Collaborator Author

sunag commented Nov 28, 2021

The support for Material.dispose() was already implemented. Do you mind explaining in more detail your changes in that context?

The old approach of Material.dispose() don't work done It was focused only on material pipeline but WebGPU work with the logic of RenderItem for all include NodeBuilder and Bindings. This approach fix manly this issue, disposing all pipeline dependencies of each object that use the material.

@mrdoob mrdoob added this to the r136 milestone Nov 29, 2021
@mrdoob mrdoob merged commit 35dfa47 into mrdoob:dev Nov 29, 2021
@mrdoob
Copy link
Owner

mrdoob commented Nov 29, 2021

Thanks!

@Mugen87
Copy link
Collaborator

Mugen87 commented Dec 11, 2021

It seems this PR broke the box with the compressed texture in webgpu_sandbox. It now looks like so:

image

@sunag
Copy link
Collaborator Author

sunag commented Dec 11, 2021

It seems this PR broke the box with the compressed texture in webgpu_sandbox. It now looks like so:

Yeah, I will fix it.

@sunag sunag mentioned this pull request Dec 11, 2021
@sunag sunag deleted the dev-node-editor-2 branch January 27, 2022 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants