WebGLRenderer: Fix texture unit allocation of morph textures. #22624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
commented
Oct 1, 2021
| @@ -1514,11 +1508,11 @@ function WebGLRenderer( parameters = {} ) { | |||
| const environment = material.isMeshStandardMaterial ? scene.environment : null; | |||
| const encoding = ( _currentRenderTarget === null ) ? _this.outputEncoding : _currentRenderTarget.texture.encoding; | |||
| const envMap = ( material.isMeshStandardMaterial ? cubeuvmaps : cubemaps ).get( material.envMap || environment ); | |||
| const vertexAlphas = material.vertexColors === true && !! object.geometry && !! object.geometry.attributes.color && object.geometry.attributes.color.itemSize === 4; | |||
There was a problem hiding this comment.
I don't think the !! object.geometry statements make sense. Render items always have a geometry, no?
There was a problem hiding this comment.
Ah wait, we need this for ImmediateRenderObject.
There was a problem hiding this comment.
I wonder if we could remove ImmediateRenderObject 🤔. This would noticeably simplify the renderer. And in that way,WebGPURenderer does not have to support ImmediateRenderObject.
Mugen87
changed the title
|
I guess we need |
This was referenced Oct 2, 2021
|
Thanks! |
This was referenced Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: Fixed #22619
Description
This PR ensures that similar to bone textures, morph textures allocated the same texture unit.