Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPU: SkinnedMesh support #22610

Merged
merged 5 commits into from
Oct 4, 2021
Merged

WebGPU: SkinnedMesh support #22610

merged 5 commits into from
Oct 4, 2021

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Sep 30, 2021

Description

It is not the design final. I will update as soon possible to implement a vertex node system more robust.

Live

https://raw.githack.com/sunag/three.js/dev-webgpu-skin/examples/webgpu_skinning.html

New Nodes

  • PositionNode.GEOMETRY -> position local without transform
  • NormalNode.GEOMETRY -> normal local without transform
  • BufferNode -> UBO array support
  • BypassNode -> used to call void functions in flow process
  • SkinningNode

This contribution is funded by Google via Igalia.

@mrdoob mrdoob added this to the r134 milestone Sep 30, 2021
@sunag
Copy link
Collaborator Author

sunag commented Oct 4, 2021

My idea was to merger this PR and publish an update soon. This implementation is not so bad and contains some features interesting for others PRs.

What do you think?

@Mugen87
Copy link
Collaborator

Mugen87 commented Oct 4, 2021

I'm definitely fine with merging this 👍 . I just would wait until r131.1 is published. There are two PRs (#22625 and #22624) that we need in prod.

@mrdoob mrdoob merged commit e57b777 into mrdoob:dev Oct 4, 2021
@mrdoob
Copy link
Owner

mrdoob commented Oct 4, 2021

Thanks!

@sunag sunag deleted the dev-webgpu-skin branch October 5, 2021 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants