Remove ImmediateRenderObject. #22643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! 🥲 |
12 tasks
|
I have a usage, such as rendering a vector tile, the material has stencilWrite: true , and I need to update the position in onBeforeRender, and I don't want to create too many buffers, ImmediateRenderObject can help me, but it is deleted now, do I have any other solutions? |
|
@cdhuangyong Could you elaborate a bit more? |
|
Because there is a lot of code, I just briefly describe the logic of the code. Sorry, I haven't been able to provide a working demo yet. If I don't consider performance issues, I can use other ways to render. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #22624 (comment)
Description
The primary intention behind this change is to simplify the renderer. Looking back, it also seems that ImmediateRenderObject was too hard to use and thus only poorly adapted by the user base. Overall, it seems better to guide user to the normal BufferGeometry workflows.