Update website_discovery.py #3921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dekkers
reviewed
Dec 2, 2024
There was a problem hiding this comment.
This change looks good, but I think we should also look into why we get "http-proxy" as service name because if I remember correctly from seeing this earlier the service name should be just "http". If we don't fix that we risk not scanning websites that should be scanned.
|
for some reason, the remote host that triggered this, no longer returns http-proxy at the moment. However, it might just be that :8080 and :8443 are named http-proxy in the nmap services file? |
ammar92
approved these changes
Dec 3, 2024
dekkers
approved these changes
Dec 4, 2024
|
jpbruinsslot
added a commit
that referenced
this pull request
Dec 11, 2024
* main: (21 commits) Bump django from 5.0.9 to 5.0.10 in /rocky (#3940) Do not let enabling plugins affect the global plugin cache (#3944) Fix typing in more places and configure mypy to follow imports (#3932) Updates CWE archive to 4.16 (#3943) Report flaws (#3880) Translations update from Hosted Weblate (#3939) Fix report recipe API (#3942) Boefje runonce functionality in scheduler (#3906) fix: 🔨 do not store CDN findings (#3931) Dont check for Locations on local Ip's. (#3894) add unpkg.com to disallowed hostnames in CSP (#3927) Update website_discovery.py (#3921) Add export http boefje (#3901) Bump python-multipart from 0.0.9 to 0.0.18 in /bytes (#3925) Fix layout issues on scheduled reports page (#3930) Create scheduled report with zero objects selectable (#3907) Improve the KATalogus `/plugins` endpoint performance (#3892) Add bgp.jsonl and bgp-meta.json to .gitignore (#3928) Update pre-commit and all hooks (#3923) add support for detecting Lame dns delegations on ip ranges (#3899) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3913
Changes
This makes sure we don't create websites on services that only begin with http such as http_proxy. As those urls cannot be handled by Boefjes later on in the chain.
Issue link
Closes #3913
Demo
Please add some proof in the form of screenshots or screen recordings to show (off) new functionality, if there are interesting new features for end-users.
QA notes
See the ISsue for an IP that returns a http_proxy service when nmapped, it should no longer also create a website on that service
Code Checklist
.envchanges files if required and changed the.env-distaccordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.