Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make some things look better #3661

Merged
merged 9 commits into from
Oct 11, 2024
Merged

make some things look better #3661

merged 9 commits into from
Oct 11, 2024

Conversation

Rieven
Copy link
Contributor

@Rieven Rieven commented Oct 9, 2024 •
edited
Loading

Changes

  • Added horizontal-scroll div wrapped around some tables.
  • Plugins table: added expando row for plugin type and description. this makes the table more compact.
  • Remove padding for final report, it already have a max-width

Demo

Major change:

Paddings final report
image

FROM THIS
image

TO THIS:
image

Mobile now is fixed for horizontal scroliing:
image

QA notes

You need to also run yarn dev or yarn build to see padding changes on the final report.

Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made.
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.
  • Tickets have been created for newly discovered issues.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.

Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@Rieven Rieven requested a review from a team as a code owner October 9, 2024 14:17
@Rieven Rieven self-assigned this Oct 9, 2024
@Rieven Rieven requested a review from HeleenSG October 9, 2024 15:08
ammar92
ammar92 reviewed Oct 10, 2024
View reviewed changes
Copy link
Contributor

@ammar92 ammar92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Tiny suggestion, but looks good otherwise

rocky/katalogus/templates/change_clearance_level.html Outdated Show resolved Hide resolved
@stephanie0x00
Copy link
Contributor

Checklist for QA:

  • I have checked out this branch, and successfully ran a fresh make reset.
  • I confirmed that there are no unintended functional regressions in this branch:
    • I have managed to pass the onboarding flow
    • Objects and Findings are created properly
    • Tasks are created and completed properly
  • I confirmed that the PR's advertised feature or hotfix works as intended.
  • I checked the logs for errors and/or warnings and made issues where necessary

What works:

Couldn't find any obvious regression, thus looks good. The exported PDF require some love (#3671 ), but that doesn't seem to be related to this PR.

What doesn't work:

n/a

Bug or feature?:

n/a

@underdarknl underdarknl merged commit 14467d3 into main Oct 11, 2024
21 checks passed
@underdarknl underdarknl deleted the fix/styling-end-report branch October 11, 2024 08:54
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

jpbruinsslot added a commit that referenced this pull request Oct 24, 2024
@jpbruinsslot
Merge branch 'main' into chore/mula/documentation
63b2ad4 
* main: (25 commits)
  Add sterr to output list (#3649)
  feat: ✨ add Shodan InternetDB boefje (#2615)
  Add search endpoint for schedules for scheduler (#3695)
  Fix/report naming (#3666)
  Add delete schedule functionality for schedules in the scheduler (#3678)
  Fix javascript and component template in prod environments (#3672)
  Fix first order dangling affirmation delete (#3682)
  Do not run dh_strip_nondeterminism in Debian packaging (#3674)
  Github action should trigger if workflow definition changes (#3680)
  Updated packages (#3694)
  Silence KATFindingType not found error in JobHandler (#3686)
  Add docs for xtdb analyze bits. (#3688)
  Fix empty vulnerability reports (#3662)
  Fix jsonb 'contained by' query (#3643)
  Add plugins to findings report (#3657)
  Translations update from Hosted Weblate (#3673)
  Update upload_raw.py (#3645)
  Add rocky worker service to debian packages (#3619)
  Fix/yielded objects (#3669)
  make some things look better (#3661)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ammar92 ammar92 ammar92 left review comments

@underdarknl underdarknl underdarknl approved these changes

@HeleenSG HeleenSG Awaiting requested review from HeleenSG

Assignees

@Rieven Rieven

Labels
None yet
Projects
KAT
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rieven @stephanie0x00 @underdarknl @ammar92