Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update upload_raw.py #3645

Merged
merged 11 commits into from
Oct 11, 2024
Merged

Update upload_raw.py #3645

merged 11 commits into from
Oct 11, 2024

Conversation

underdarknl
Copy link
Contributor

fixes #3641

Changes

adds check for required fields

Issue link

Closes #3641

QA notes

raw file uploads should not crash when submitting empty forms

Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made.
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.
  • Tickets have been created for newly discovered issues.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@underdarknl underdarknl requested a review from a team as a code owner October 8, 2024 13:39
ammar92
ammar92 previously approved these changes Oct 8, 2024
ammar92
ammar92 previously approved these changes Oct 10, 2024
Copy link
Contributor

@ammar92 ammar92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more remarks

@stephanie0x00
Copy link
Contributor

QA notes:

  • The addition of the 'required' fields didn't solve the issue. Submitting the empty form still results in the ooi_id keyerror.

Copy link

sonarcloud bot commented Oct 11, 2024

@ammar92
Copy link
Contributor

ammar92 commented Oct 11, 2024

Seems to work again after the latest commit. I was able to use the form and trigger a normalizer task manually

@dekkers dekkers merged commit 08aa9e0 into main Oct 11, 2024
22 checks passed
@dekkers dekkers deleted the fix/3641-missing-fields-raw-upload branch October 11, 2024 18:06
jpbruinsslot added a commit that referenced this pull request Oct 24, 2024
* main: (25 commits)
  Add sterr to output list (#3649)
  feat: ✨ add Shodan InternetDB boefje (#2615)
  Add search endpoint for schedules for scheduler (#3695)
  Fix/report naming (#3666)
  Add delete schedule functionality for schedules in the scheduler (#3678)
  Fix javascript and component template in prod environments (#3672)
  Fix first order dangling affirmation delete (#3682)
  Do not run dh_strip_nondeterminism in Debian packaging (#3674)
  Github action should trigger if workflow definition changes (#3680)
  Updated packages (#3694)
  Silence KATFindingType not found error in JobHandler (#3686)
  Add docs for xtdb analyze bits. (#3688)
  Fix empty vulnerability reports (#3662)
  Fix jsonb 'contained by' query (#3643)
  Add plugins to findings report (#3657)
  Translations update from Hosted Weblate (#3673)
  Update upload_raw.py (#3645)
  Add rocky worker service to debian packages (#3619)
  Fix/yielded objects (#3669)
  make some things look better (#3661)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Uploading raw file without required fields gives KeyError
4 participants