Fix jsonb 'contained by' query #3643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammar92
reviewed
Oct 10, 2024
Thanks for reviewing 💪 |
Checklist for QA:
What works:Seems to work. Scheduled a bunch of tasks and then filtered on each of the task filters to see if it would work. Also checked the logs for the scheduler, rocky, octopoes_api, octopoes_api_worker and bytes to check for any error messages that might be side effects. No obvious bugs found. What doesn't work:n/a Bug or feature?:n/a |
underdarknl
approved these changes
Oct 14, 2024
|
jpbruinsslot
added a commit
that referenced
this pull request
Oct 24, 2024
* main: (25 commits) Add sterr to output list (#3649) feat: ✨ add Shodan InternetDB boefje (#2615) Add search endpoint for schedules for scheduler (#3695) Fix/report naming (#3666) Add delete schedule functionality for schedules in the scheduler (#3678) Fix javascript and component template in prod environments (#3672) Fix first order dangling affirmation delete (#3682) Do not run dh_strip_nondeterminism in Debian packaging (#3674) Github action should trigger if workflow definition changes (#3680) Updated packages (#3694) Silence KATFindingType not found error in JobHandler (#3686) Add docs for xtdb analyze bits. (#3688) Fix empty vulnerability reports (#3662) Fix jsonb 'contained by' query (#3643) Add plugins to findings report (#3657) Translations update from Hosted Weblate (#3673) Update upload_raw.py (#3645) Add rocky worker service to debian packages (#3619) Fix/yielded objects (#3669) make some things look better (#3661) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Queries using lists as filter values when using it in combination with a 'contained_by' operator (
<@) were incorrectly interpreted as text, and as such would create an incorrect SQL query.Issue link
Closes #3627
References #3299 (comment)
QA notes
Api functionality from scheduler to filter on the
/tasksand/queuesendpoint using jsonb operator are mainly addressed here. Since we don't yet use this, this pr should not intervene with current functionality. So mainly filtering of tasks in rocky should be main area where something might happen. Checking that out would probably be a good thing.I'm trying to find some good qa examples, to test the functionality in this pr. But having issues with using curl and how characters are getting escaped and interpreted by fastapi. So stay tuned for that.
Code Checklist
.envchanges files if required and changed the.env-distaccordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.