Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC Remove mention of cycle_hour from reliability calibration #1657

Merged
merged 1 commit into from
Feb 2, 2022
Merged

DOC Remove mention of cycle_hour from reliability calibration #1657

merged 1 commit into from
Feb 2, 2022

Conversation

lucyleeow
Copy link
Contributor

Following from #1170, removes remaining mentions of cycle/cycle_hour in reliability calibration.

ping @bayliffe who created the original PR.

Testing:

  • [n/a] Ran tests and they passed OK
  • [n/a] Added new tests for the new feature(s)

@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #1657 (034a39b) into master (8eb0e74) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1657   +/-   ##
=======================================
  Coverage   98.18%   98.18%           
=======================================
  Files         110      110           
  Lines       10098    10098           
=======================================
  Hits         9915     9915           
  Misses        183      183
Impacted Files Coverage Δ
improver/calibration/reliability_calibration.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8eb0e74...034a39b. Read the comment docs.

@Kat-90 Kat-90 self-requested a review February 2, 2022 07:47
Kat-90
Kat-90 approved these changes Feb 2, 2022
View reviewed changes
Copy link
Contributor

@Kat-90 Kat-90 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed changes to doc strings and the update to example calibration table.
Checked that "cycle_hour" does not appear in any other IMPROVER code and Compared with changes made in #1170.
Happy to approve the first review.

@Kat-90 Kat-90 assigned Kat-90 and unassigned Kat-90 Feb 2, 2022
@gavinevans gavinevans self-assigned this Feb 2, 2022
gavinevans
gavinevans approved these changes Feb 2, 2022
View reviewed changes
Copy link
Contributor

@gavinevans gavinevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lucyleeow 👍

This looks fine to me.

@gavinevans gavinevans merged commit 6e894f1 into metoppv:master Feb 2, 2022
@lucyleeow lucyleeow deleted the cycle_frt branch February 3, 2022 02:46
MoseleyS added a commit to MoseleyS/improver that referenced this pull request Feb 4, 2022
@MoseleyS
Merge branch 'master' into mobt_161_wxcode_tree_check
c6a5923 
* master:
  remove cycle (metoppv#1657)
  Minor edits to remove raising unnecessary warnings. (metoppv#1646)
  Adds handling of a model-id-attr to wxcode-modal (metoppv#1634)

# Conflicts:
#	improver_tests/acceptance/SHA256SUMS
fionaRust added a commit that referenced this pull request Feb 4, 2022
@fionaRust
Merge branch 'master' into feature_branch_nbhood_refactor
1388dde 
* master:
  Modifies wxcode check_tree utility function to report issues with unreachable nodes (#1637)
  remove cycle (#1657)
  Minor edits to remove raising unnecessary warnings. (#1646)
  Change pandas DataFrame.at to DataFrame.loc (#1655)
  Adds handling of a model-id-attr to wxcode-modal (#1634)
MoseleyS added a commit to MoseleyS/improver that referenced this pull request Feb 9, 2022
@MoseleyS
Merge branch 'master' into mobt127_filter_in_combine
a3f8e9c 
* master:
  Modifies wxcode check_tree utility function to report issues with unreachable nodes (metoppv#1637)
  remove cycle (metoppv#1657)
  Minor edits to remove raising unnecessary warnings. (metoppv#1646)
  Change pandas DataFrame.at to DataFrame.loc (metoppv#1655)
  Adds handling of a model-id-attr to wxcode-modal (metoppv#1634)

# Conflicts:
#	improver_tests/acceptance/SHA256SUMS
fionaRust added a commit to fionaRust/improver that referenced this pull request Feb 23, 2022
@fionaRust
Merge branch 'feature_branch_nbhood_refactor' into mobt_157_nbhood_re…
dd3b727 
…factor_tidy_CLIs

* feature_branch_nbhood_refactor:
  Mobt 157 nbhood refactor consolidate unit tests rebased (metoppv#1664)
  Mobt 157 nbhood refactor consolidate unit tests part1 (metoppv#1665)
  Adds a filter to the combine CLI for mismatching realizations (metoppv#1656)
  Reduce the memory requirements for read-the-docs (metoppv#1672)
  Further doc-building fixes. (metoppv#1671)
  DOC Fix intersphinx links for docs (metoppv#1668)
  Mobt 157 nbhood refactor sort out base classes (metoppv#1653)
  Modifies wxcode check_tree utility function to report issues with unreachable nodes (metoppv#1637)
  remove cycle (metoppv#1657)
  Minor edits to remove raising unnecessary warnings. (metoppv#1646)
  Change pandas DataFrame.at to DataFrame.loc (metoppv#1655)
  MOBT-154: Reunification of wx decision trees (metoppv#1639)
  Consolidate scale parameter usage across EMOS and ECC (metoppv#1642)
  Adds handling of a model-id-attr to wxcode-modal (metoppv#1634)
MoseleyS pushed a commit to MoseleyS/improver that referenced this pull request Aug 22, 2024
remove cycle (metoppv#1657)
11c0046
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kat-90 Kat-90 Kat-90 approved these changes

@gavinevans gavinevans gavinevans approved these changes

Assignees

@gavinevans gavinevans

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucyleeow @gavinevans @Kat-90