Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Fix intersphinx links for docs #1668

Merged
merged 2 commits into from
Feb 9, 2022
Merged

Conversation

lucyleeow
Copy link
Contributor

@lucyleeow lucyleeow commented Feb 8, 2022

Fix numpy and scipy intersphinx links as docs currently failing (see #1667) with error:

intersphinx inventory 'https://docs.scipy.org/doc/scipy/reference/objects.inv' not readable due to ValueError: unknown or unsupported inventory version: ValueError('invalid inventory header: ')

Note ongoing hosting issue for scipy hosting: scipy/scipy#14267
I linked to scipy 1.6.2 as this is what we test with in CI but can switch this to 1.8.0 (https://docs.scipy.org/doc/scipy-1.8.0/html-scipyorg/)

Testing:

  • Ran tests and they passed OK
  • [n/a] Added new tests for the new feature(s)

@lucyleeow lucyleeow changed the title DOC Fix scipy intersphinx link for docs DOC Fix intersphinx links for docs Feb 8, 2022
@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #1668 (2f74b6f) into master (e154e72) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1668   +/-   ##
=======================================
  Coverage   98.18%   98.18%           
=======================================
  Files         110      110           
  Lines       10110    10110           
=======================================
  Hits         9927     9927           
  Misses        183      183           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e154e72...2f74b6f. Read the comment docs.

Copy link
Contributor

@gavinevans gavinevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lucyleeow 👍

I think that these changes look fine to me.

@gavinevans gavinevans assigned Kat-90 and unassigned gavinevans Feb 9, 2022
Copy link
Contributor

@Kat-90 Kat-90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked the github actions logs and can see the failing intersphinx inventories have now been fixed.
Happy to approve.

@Kat-90 Kat-90 merged commit 4f9c0aa into metoppv:master Feb 9, 2022
MoseleyS added a commit to MoseleyS/improver that referenced this pull request Feb 15, 2022
* master:
  DOC Fix intersphinx links for docs (metoppv#1668)
fionaRust added a commit to fionaRust/improver that referenced this pull request Feb 15, 2022
* master:
  Adds a filter to the combine CLI for mismatching realizations (metoppv#1656)
  Reduce the memory requirements for read-the-docs (metoppv#1672)
  Further doc-building fixes. (metoppv#1671)
  DOC Fix intersphinx links for docs (metoppv#1668)
fionaRust added a commit to fionaRust/improver that referenced this pull request Feb 15, 2022
…factor_consolidate_unit_tests_part1

* feature_branch_nbhood_refactor:
  Adds a filter to the combine CLI for mismatching realizations (metoppv#1656)
  Reduce the memory requirements for read-the-docs (metoppv#1672)
  Further doc-building fixes. (metoppv#1671)
  DOC Fix intersphinx links for docs (metoppv#1668)
fionaRust added a commit to fionaRust/improver that referenced this pull request Feb 16, 2022
…factor_consolidate_unit_tests_rebased

* feature_branch_nbhood_refactor:
  Mobt 157 nbhood refactor consolidate unit tests part1 (metoppv#1665)
  Adds a filter to the combine CLI for mismatching realizations (metoppv#1656)
  Reduce the memory requirements for read-the-docs (metoppv#1672)
  Further doc-building fixes. (metoppv#1671)
  DOC Fix intersphinx links for docs (metoppv#1668)
fionaRust added a commit to fionaRust/improver that referenced this pull request Feb 23, 2022
…factor_tidy_CLIs

* feature_branch_nbhood_refactor:
  Mobt 157 nbhood refactor consolidate unit tests rebased (metoppv#1664)
  Mobt 157 nbhood refactor consolidate unit tests part1 (metoppv#1665)
  Adds a filter to the combine CLI for mismatching realizations (metoppv#1656)
  Reduce the memory requirements for read-the-docs (metoppv#1672)
  Further doc-building fixes. (metoppv#1671)
  DOC Fix intersphinx links for docs (metoppv#1668)
  Mobt 157 nbhood refactor sort out base classes (metoppv#1653)
  Modifies wxcode check_tree utility function to report issues with unreachable nodes (metoppv#1637)
  remove cycle (metoppv#1657)
  Minor edits to remove raising unnecessary warnings. (metoppv#1646)
  Change pandas DataFrame.at to DataFrame.loc (metoppv#1655)
  MOBT-154: Reunification of wx decision trees (metoppv#1639)
  Consolidate scale parameter usage across EMOS and ECC (metoppv#1642)
  Adds handling of a model-id-attr to wxcode-modal (metoppv#1634)
MoseleyS pushed a commit to MoseleyS/improver that referenced this pull request Aug 22, 2024
* try scipy intersphinx link

* update numpy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants