Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Remove mention of cycle_hour from reliability calibration #1657

Merged
merged 1 commit into from
Feb 2, 2022
Merged

DOC Remove mention of cycle_hour from reliability calibration #1657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...tation/calibration/reliability_calibration/reliability_calibration_examples.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ The reliability calibration tables returned by this plugin are structured as sho
Auxiliary coordinates:
table_row_name - x - - -
Scalar coordinates:
cycle_hour: 22
forecast_reference_time: 2017-11-11 00:00:00, bound=(2017-11-10 00:00:00, 2017-11-11 00:00:00)
forecast_period: 68400 seconds
Attributes:
institution: Met Office
Expand Down
13 changes: 7 additions & 6 deletions improver/calibration/reliability_calibration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,10 +233,11 @@ def _create_reliability_table_cube(
) -> Cube:
"""
Construct a reliability table cube and populate it with the provided
data. The returned cube will include a cycle hour coordinate, which
describes the model cycle hour at which the forecast data was produced.
It will further include the forecast period, threshold coordinate,
and spatial coordinates from the forecast cube.
data. The returned cube will include a forecast_reference_time
coordinate, which will be the maximum range of bounds of the input
forecast reference times, with the point value set to the latest
of those in the inputs. It will further include the forecast period,
threshold coordinate, and spatial coordinates from the forecast cube.

Args:
forecast:
Expand Down Expand Up @@ -443,11 +444,11 @@ def process(self, historic_forecasts: Cube, truths: Cube) -> Cube:
whether the data is thresholded below or above a given diagnostic
threshold.

`historic_forecasts` and `truths` should have matching validity times.

Args:
historic_forecasts:
A cube containing the historical forecasts used in calibration.
These are expected to all have a consistent cycle hour, that is
the hour in the forecast reference time.
truths:
A cube containing the thresholded gridded truths used in
calibration.
Expand Down