Ignore more stray timelines in Accumulate #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Described in #211 (comment). This is essentially cherry picked from #248, in particular the commit 8c7046e This should prevent creating new snapshots that don't reflect the state of the room. We'll need a followup task to clean up bad snapshots.
|
I will need to
|
|
Easier than I expected to get the tests happy. It looks like the test changes in #248 are fixups to ensuring that we never send a nonempty state block with an empty timeline. This PR targets empty state blocks and nonempty timelines, so I think that is irrelevant here. |
DMRobertson
pushed a commit
that referenced
this pull request
Aug 22, 2023
These rooms have invalid state snapshots, leading to correctness problems. The existence of such snapshots leaves us open to performance problems due to gappy state updates. We have prevented invalid state snapshots from being formed (#255, #266) in the future. The remaining hole is to discard existing invalid snapshots. Closes #256.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Described in #211 (comment).
This is essentially cherry picked from #248, in particular the commit
8c7046e
This should prevent creating new snapshots that don't reflect the state of the room. We'll need a followup task to clean up bad snapshots.