Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to clean up bogus rooms #267

Merged
merged 4 commits into from
Aug 23, 2023
Merged

Migration to clean up bogus rooms #267

merged 4 commits into from
Aug 23, 2023

Conversation

DMRobertson
Copy link
Contributor

These rooms have invalid state snapshots, leading to correctness problems. The existence of such snapshots leaves us open to performance problems due to gappy state updates.

We have prevented invalid state snapshots from being formed (#255, #266) in the future. The remaining hole is to discard existing invalid snapshots.

Closes #256.

These rooms have invalid state snapshots, leading to correctness
problems. The existence of such snapshots leaves us open to performance
problems due to gappy state updates.

We have prevented invalid state snapshots from being formed (#255, #266)
in the future. The remaining hole is to discard existing invalid
snapshots.

Closes #256.
Copy link
Member

@kegsay kegsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get some data on how many rooms were affected? It would be nice to have as a sanity check when running this.

@DMRobertson
Copy link
Contributor Author

Can we get some data on how many rooms were affected? It would be nice to have as a sanity check when running this.

I was thinking the same. I guess I will have to write the migration in go for this?

@DMRobertson
Copy link
Contributor Author

I'll need to test this somehow.

so we can have meaningful logging
@DMRobertson DMRobertson force-pushed the dmr/migration-cleanup branch from 3da8b25 to 7cbefdf Compare August 22, 2023 18:11
Co-authored-by: kegsay <[email protected]>
@DMRobertson DMRobertson marked this pull request as ready for review August 23, 2023 16:35
@DMRobertson
Copy link
Contributor Author

Tested manually in a staging environment and then with a gradual rollout.

@DMRobertson DMRobertson merged commit 249c61a into main Aug 23, 2023
@DMRobertson DMRobertson deleted the dmr/migration-cleanup branch August 23, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up bad snapshots from existing databases.
2 participants