WIP: create new state snapshots on join #248
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per #211 - this combines Initialise and Accumulate into a single ProcessRoomEvents functions which can do snapshots / timelines. Implements the "brand new snapshot on create event" logic, which currently does not correctly invalidate caches. E2E tests pass, but integ tests are broken.
DMRobertson
pushed a commit
that referenced
this pull request
Aug 17, 2023
Described in #211 (comment). This is essentially cherry picked from #248, in particular the commit 8c7046e This should prevent creating new snapshots that don't reflect the state of the room. We'll need a followup task to clean up bad snapshots.
This was referenced Aug 17, 2023
|
Closing as dmr has ended up doing something different here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #211 by implementing #232.