-
-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Media Devices Mid-call #1977
Conversation
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! How plausible would it be write a test for this?
Yes, a test would be great and I can add one. I want to hold off on this longer though. I have some edits that I've made in my branch for GroupCalls and am still going over some bugs in Safari that may or may not be related. |
This PR adds the ability to change media devices mid-call using the
mediaHandler.setAudioDevice
and.setVideoDevice
methods. Calls will automatically be renegotiated for the new media. Note that this implementation attempts to use sender.replaceTrack() which avoids renegotiation. In the case where we cannot replace the existing track, it adds a new track and renegotiates the connection.Depends on #1972
Notes:
MediaHandler.setAudioDevice
and.setVideoDevice
now return a promise which can be awaited to determine if setting the new device was successful.Here's what your changelog entry will look like:
🚨 BREAKING CHANGES