-
-
Notifications
You must be signed in to change notification settings - Fork 829
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some methods of MediaHandler
are now async, could we please also update the ones in MediaDeviceHandler
to be async too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this lgtm
@SimonBrandner - updating the class to be async feels like a different PR's concern? If we're not using the async functionality in the react-sdk, it's fine to keep it sync.
I guess so, though it would be nice to do it before we (or I at least) forget they're async :D |
True though the react-sdk class has wrapper functions which are not async which the IDE won't help with |
@robertlong fyi we don't merge people's changes for them if they have commit access to the repo, just in case there's sensitivity to things landing. This appears to be open still - was it intending to be merged? |
IIRC, @robertlong has mentioned there were some unresolved concerns with this. Though I would appreciate this moving forward as #7173 is blocked on this |
Companion to matrix-org/matrix-js-sdk#1977 in which we add support for changing media devices mid-call. In the matrix-react-sdk this requires a one line change which updates the stream in the
VideoFeed
when it changes.Here's what your changelog entry will look like:
✨ Features
Preview: https://6165fcc949fb1e009f8278fd--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.