Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for mid-call devices changes #2154

Merged
merged 9 commits into from
Feb 25, 2022

Conversation

SimonBrandner
Copy link
Contributor

@SimonBrandner SimonBrandner commented Feb 4, 2022

Type: enhancement
Replaces and closes #1977
Blocked on #2157


Here's what your changelog entry will look like:

✨ Features

@SimonBrandner SimonBrandner force-pushed the feature/mid-call-device-change branch from a5e971a to 9e82210 Compare February 5, 2022 12:02
@SimonBrandner SimonBrandner force-pushed the feature/mid-call-device-change branch 4 times, most recently from 8316208 to b47e8a3 Compare February 6, 2022 15:07
@SimonBrandner SimonBrandner marked this pull request as ready for review February 6, 2022 15:14
@SimonBrandner SimonBrandner requested a review from a team as a code owner February 6, 2022 15:14
@SimonBrandner SimonBrandner marked this pull request as draft February 6, 2022 15:17
@SimonBrandner SimonBrandner marked this pull request as ready for review February 6, 2022 15:18
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner SimonBrandner force-pushed the feature/mid-call-device-change branch from b47e8a3 to f4a6ab1 Compare February 9, 2022 19:28
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks plausible! Do this and the react-sdk PR mutually require each other? Does that imply this is a breaking change?

@SimonBrandner
Copy link
Contributor Author

Ah, actually, seems to be fine without the react-sdk part, not sure why I put it into the description

@SimonBrandner SimonBrandner requested a review from dbkr February 22, 2022 17:14
@dbkr dbkr merged commit 53aa34f into matrix-org:develop Feb 25, 2022
@SimonBrandner SimonBrandner deleted the feature/mid-call-device-change branch February 25, 2022 14:53
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this pull request Mar 17, 2022
* Improve typing around event emitter handlers ([\matrix-org#2180](matrix-org#2180)).
* Fix defer not supporting resolving with a Promise<T> ([\matrix-org#2216](matrix-org#2216)).
* add LocationAssetType enum ([\matrix-org#2214](matrix-org#2214)).
* Support for mid-call devices changes ([\matrix-org#2154](matrix-org#2154)). Contributed by @SimonBrandner.
* Add new room state emit RoomStateEvent.Update for lower-frequency hits ([\matrix-org#2192](matrix-org#2192)).
* Fix wrong event_id being sent for m.in_reply_to of threads ([\matrix-org#2213](matrix-org#2213)).
* Fix wrongly asserting that PushRule::conditions is non-null ([\matrix-org#2217](matrix-org#2217)).
* Make createThread more resilient when missing rootEvent ([\matrix-org#2207](matrix-org#2207)). Fixes element-hq/element-web#21130.
* Fix bug with the /hierarchy API sending invalid requests ([\matrix-org#2201](matrix-org#2201)). Fixes element-hq/element-web#21170.
* fix relation sender filter ([\matrix-org#2196](matrix-org#2196)). Fixes element-hq/element-web#20877.
* Fix bug with one-way audio after a transfer ([\matrix-org#2193](matrix-org#2193)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants