Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRA: remove "classic DRA" #48289

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

pohly
Copy link
Contributor

@pohly pohly commented Oct 11, 2024

Description

This matches kubernetes/kubernetes#128003.

Issue

Related-to: kubernetes/enhancements#3063

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Oct 11, 2024
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 11, 2024
@pohly pohly changed the base branch from main to dev-1.32 October 11, 2024 15:19
@pohly pohly force-pushed the dra-classic-dra-removal branch from 894bb19 to 10c9383 Compare October 14, 2024 06:50
Copy link

netlify bot commented Oct 14, 2024

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit b181560
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6720afc9f3857a0008227ef4

@pohly pohly force-pushed the dra-classic-dra-removal branch from 10c9383 to dff8243 Compare October 14, 2024 07:00
Copy link

netlify bot commented Oct 14, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit b181560
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6720afc9e27bab0008c323ee
😎 Deploy Preview https://deploy-preview-48289--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pohly pohly force-pushed the dra-classic-dra-removal branch from dff8243 to 501066f Compare October 14, 2024 11:21
@pohly pohly force-pushed the dra-classic-dra-removal branch from 501066f to 03d880c Compare October 14, 2024 14:31
@sftim
Copy link
Contributor

sftim commented Oct 14, 2024

/milestone 1.32
/sig node

@k8s-ci-robot k8s-ci-robot added this to the 1.32 milestone Oct 14, 2024
@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Oct 14, 2024
@pohly
Copy link
Contributor Author

pohly commented Oct 14, 2024

/assign @klueska

@pohly
Copy link
Contributor Author

pohly commented Oct 14, 2024

/wg device-management

@k8s-ci-robot k8s-ci-robot added the wg/device-management Categorizes an issue or PR as relevant to WG Device Management. label Oct 14, 2024
Copy link
Contributor

@klueska klueska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment otherwise LGTM

Co-authored-by: Kevin Klues <[email protected]>
@klueska
Copy link
Contributor

klueska commented Oct 29, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: bc98e354a8163c0baca00fd0176123d4612965b5

@pohly
Copy link
Contributor Author

pohly commented Oct 31, 2024

/assign @nate-double-u

For approval.

Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dipesh-rawat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2024
@k8s-ci-robot k8s-ci-robot merged commit 02adfc2 into kubernetes:dev-1.32 Nov 11, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. wg/device-management Categorizes an issue or PR as relevant to WG Device Management.
Development

Successfully merging this pull request may close these issues.

6 participants