Remove workingdir image in favor of adding cwd information to the runtime image. #4679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
the
size/XL
There was a problem hiding this comment.
@markusthoemmes: 0 warnings.
In response to this:
Proposed Changes
- Add "cwd" to the runtime image information of the user.
- Rework the working dir tests to make use of that information.
- Remove the working dir image.
Release Note
NONE/assign @dgerd
/assign @vagababov
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markusthoemmes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
approved
vagababov
reviewed
Jul 10, 2019
knative-prow-robot
added
do-not-merge/hold
|
@vagababov it's based on the other PR. Once that merges I'll rebase this. |
markusthoemmes
force-pushed
the
remove-workingdir-image
branch
from
156481f to
2db192a
Compare
knative-prow-robot
added
size/L
|
/hold cancel |
knative-prow-robot
removed
the
do-not-merge/hold
|
/test pull-knative-serving-integration-tests |
1 similar comment
|
/test pull-knative-serving-integration-tests |
dgerd
reviewed
Jul 10, 2019
|
/lgtm |
dgerd
pushed a commit
to dgerd/serving
that referenced
this pull request
Jul 11, 2019
The Runtime test image allows us to easily capture "PORT" from the returned environment variables. This test also removes the setting the userPort in the Service test as that functionality is now being tested by the runtime enviornment variable MUST test. Ref knative#4679
knative-prow-robot
pushed a commit
that referenced
this pull request
Jul 11, 2019
The Runtime test image allows us to easily capture "PORT" from the returned environment variables. This test also removes the setting the userPort in the Service test as that functionality is now being tested by the runtime enviornment variable MUST test. Ref #4679
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #4677
Ref #2727
Proposed Changes
Release Note
/assign @dgerd
/assign @vagababov