Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove protocols image by moving the info into the runtime image. #4677

Merged
merged 4 commits into from
Jul 10, 2019
Merged

Remove protocols image by moving the info into the runtime image. #4677

merged 4 commits into from
Jul 10, 2019

Conversation

markusthoemmes
Copy link
Contributor

@markusthoemmes markusthoemmes commented Jul 10, 2019 •
edited
Loading

Ref: #2727

Proposed Changes

  • Make the runtime image serve http2 as well.
  • Move the request protocol into the runtime image's returned information.
  • Rework the protocols test to make use of the runtime image.
  • Delete the protocols image.

Release Note

NONE

/assign @dgerd

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 10, 2019
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 10, 2019
knative-prow-robot
knative-prow-robot reviewed Jul 10, 2019
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markusthoemmes: 0 warnings.

In response to this:

Fixes #

Proposed Changes

  • Move the FetchRuntimeInfo into the more general conformance suite.
  • Make the runtime image serve http2 as well.
  • Move the request protocol into the runtime image's returned information.
  • Rework the protocols test to make use of the runtime image.
  • Delete the protocols image.

Release Note

NONE

/assign @dgerd

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the area/test-and-release It flags unit/e2e/conformance/perf test issues for product features label Jul 10, 2019
@knative-prow-robot knative-prow-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2019
@markusthoemmes markusthoemmes force-pushed the remove-protocols-image branch from 1cfd09a to b71cb69 Compare July 10, 2019 08:17
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2019
@markusthoemmes markusthoemmes mentioned this pull request Jul 10, 2019
Merged
@markusthoemmes
Copy link
Contributor Author

/test pull-knative-serving-upgrade-tests

/assign @vagababov

@adrcunha
Copy link
Contributor

/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrcunha, markusthoemmes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

vagababov
vagababov reviewed Jul 10, 2019
View reviewed changes
Copy link
Contributor

@vagababov vagababov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2019
@markusthoemmes
Copy link
Contributor Author

/hold

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 10, 2019
@markusthoemmes
Copy link
Contributor Author

/hold cancel

Wrong window 😂

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 10, 2019
@markusthoemmes
Copy link
Contributor Author

/hold

By request from @dgerd

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 10, 2019
@dgerd
Copy link

dgerd commented Jul 10, 2019

As the protocols test is really testing behavior defined in the runtime contract ( See https://github.com/knative/serving/blob/master/docs/runtime-contract.md#protocols-and-ports ), moving the protocol test to the runtime test folder seems more appropriate than moving the fetchRuntimeInfo method out.

This should also simplify things a bit.

@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2019
@knative-prow-robot knative-prow-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 10, 2019
@markusthoemmes
Copy link
Contributor Author

/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 10, 2019
@markusthoemmes
Copy link
Contributor Author

/test pull-knative-serving-integration-tests

dgerd
dgerd reviewed Jul 10, 2019
View reviewed changes
Copy link

@dgerd dgerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2019
@knative-prow-robot knative-prow-robot merged commit 3f32b0b into knative:master Jul 10, 2019
@nak3 nak3 mentioned this pull request Jul 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgerd dgerd dgerd left review comments

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@vagababov vagababov vagababov left review comments

@adrcunha adrcunha Awaiting requested review from adrcunha

@coryrc coryrc Awaiting requested review from coryrc

Assignees

@vagababov vagababov

@dgerd dgerd

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@markusthoemmes @adrcunha @knative-prow-robot @dgerd @vagababov @googlebot