Remove printport image from test images #4720
Conversation
The Runtime test image allows us to easily capture "PORT" from the returned environment variables. This test also removes the setting the userPort in the Service test as that functionality is now being tested by the runtime enviornment variable MUST test. Ref knative#4679
knative-prow-robot
added
size/L
There was a problem hiding this comment.
@dgerd: 0 warnings.
In response to this:
The Runtime test image allows us to easily capture "PORT" from the returned
environment variables. This test also removes the setting the userPort
in the Service test as that functionality is now being tested by the
runtime enviornment variable MUST test.Ref #4679
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
knative-prow-robot
added
the
area/test-and-release
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgerd, vagababov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The Runtime test image allows us to easily capture "PORT" from the returned
environment variables. This test also removes the setting the userPort
in the Service test as that functionality is now being tested by the
runtime enviornment variable MUST test.
Ref #4679