Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move config validators check to validate only when required #3199

Merged
merged 15 commits into from
Dec 13, 2022
Merged

feat: move config validators check to validate only when required #3199

merged 15 commits into from
Dec 13, 2022

Conversation

jeronimoalbi
Copy link
Member

Closes #3194

@jeronimoalbi jeronimoalbi requested a review from ilgooz as a code owner November 29, 2022 14:30
@jeronimoalbi jeronimoalbi self-assigned this Nov 29, 2022
@jeronimoalbi jeronimoalbi marked this pull request as draft November 29, 2022 14:31
@lumtis
Copy link
Contributor

lumtis commented Nov 29, 2022

Thanks
Can we try to merge this one first #3183?
There's gonna be multiple conflicts

@jeronimoalbi
Copy link
Member Author

jeronimoalbi commented Nov 29, 2022 •
edited
Loading

Can we try to merge this one first #3183?

Yes, I will remove this one from draft once that one is merged 👍

@jeronimoalbi jeronimoalbi marked this pull request as ready for review December 9, 2022 14:20
@jeronimoalbi jeronimoalbi requested a review from Pantani as a code owner December 9, 2022 14:20
aljo242
aljo242 reviewed Dec 9, 2022
View reviewed changes
ignite/config/chain/config.go Outdated Show resolved Hide resolved
ignite/services/chain/chain.go Outdated Show resolved Hide resolved
ignite/services/chain/chain.go Outdated Show resolved Hide resolved
@jeronimoalbi jeronimoalbi mentioned this pull request Dec 13, 2022
Closed
tbruyelle
tbruyelle approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@tbruyelle tbruyelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice add this new FirstValidator func!

@aljo242 aljo242 merged commit 63e8582 into main Dec 13, 2022
@aljo242 aljo242 deleted the feat/flexible-config-validators-check branch December 13, 2022 13:49
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
@jeronimoalbi
feat: move config validators check to validate only when required (ig…
84384c7 
…nite#3199)

* feat: move config validators check to validate only when required

* chore: remove unnecessary error check

* fix: change `Chain.RPCPublicAddress` to return default address on error

* chore: fix duplicated import import

* chore: fix typo

Co-authored-by: Alex Johnson <[email protected]>

* chore: changes from review

Co-authored-by: Alex Johnson <[email protected]>

Co-authored-by: Alex Johnson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lumtis lumtis lumtis left review comments

@tbruyelle tbruyelle tbruyelle approved these changes

@aljo242 aljo242 aljo242 approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

@fadeev fadeev Awaiting requested review from fadeev

@Pantani Pantani Awaiting requested review from Pantani Pantani is a code owner

Assignees

@jeronimoalbi jeronimoalbi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the at least one validator condition in config.yml validation
4 participants
@jeronimoalbi @lumtis @tbruyelle @aljo242