Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the at least one validator condition in config.yml validation #3194

Closed
lumtis opened this issue Nov 29, 2022 · 0 comments · Fixed by #3199
Closed

Remove the at least one validator condition in config.yml validation #3194

lumtis opened this issue Nov 29, 2022 · 0 comments · Fixed by #3199
Assignees
Labels

Comments

@lumtis
Copy link
Contributor

lumtis commented Nov 29, 2022

The current to validate a config.yml fails if no validator is defined in the config.

I propose removing this check.

validators is used for the serve command for local experimentation of the chain.
However, config.yml has more usage than just for the serve command.
The config can contain build instructions that can be used for the build command to build the binary.
The network commands also read the config for build instruction without reading the validators.
The genesis config option for chain publish must contain no validator (although this one follow another validation routine)

Validator check should not be part of the verification for a minimal valid config. This check should specifically belong to the serve command, or in general a feature specific check should belong to the associated command

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants