-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(chain
): make config optional for init phase
#3183
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumtis
requested review from
ilgooz,
aljo242,
fadeev,
jeronimoalbi and
tbruyelle
as code owners
November 29, 2022 02:52
aljo242
reviewed
Nov 29, 2022
Co-authored-by: Jerónimo Albi <[email protected]>
jeronimoalbi
previously approved these changes
Dec 5, 2022
jeronimoalbi
reviewed
Dec 6, 2022
jeronimoalbi
reviewed
Dec 6, 2022
jeronimoalbi
previously approved these changes
Dec 8, 2022
tbruyelle
previously approved these changes
Dec 8, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3183 +/- ##
==========================================
- Coverage 19.91% 19.91% -0.01%
==========================================
Files 385 385
Lines 30460 30463 +3
==========================================
Hits 6066 6066
- Misses 23810 23813 +3
Partials 584 584
|
aljo242
approved these changes
Dec 8, 2022
tbruyelle
approved these changes
Dec 9, 2022
jeronimoalbi
approved these changes
Dec 9, 2022
Pantani
approved these changes
Dec 9, 2022
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
* init config optional * option change * fix validator * fix chain * changelog * fix some errors * fix keyring backend * fix prepare * Update ignite/services/chain/init.go Co-authored-by: Jerónimo Albi <[email protected]> * refactor error * remove rpc address * add init args * thomas simplification * comments * fix keyring backend genesis show Co-authored-by: Jerónimo Albi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow launching a chain with Ignite Network without a
config.yml
This doesn't fix #3166
However:
We can't really fix the initial issue about config with no validator without changing the genesis validation logic. When
config.yml
exists, network commands will read it because it may contain instruction for the build process like the main entrypoint if several main exists.The solution is to tolerate no validator for a
config.yml
, and could eventually make sense to consider because the fact that a config can contain information for building process mean that the minimal set content of a config can be used solely for this and so can contain no validator, which is used for experimenting the chainThe second issue
--no-check
that fails if the config is not valid, is because even if we don't interact with the chain locally when--no-check
is provided, we still initialize achain
object that needs read the config to be initialized. The solution is to refactor thechain
object innetworkchain
(separating the chain as information about source about the chain as a local source code)Creating separate issues for the above so #3166 can be closed