feat: plugin system (rebased) #2877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A plugin is a binary that can communicate with ignite using github.com/hashicorp/go-plugin. When ignite is executed under a chain configuration, it checks if the config contains plugins. If yes the plugins are fetched, compiled and ran, which will add more commands to the existing ones. Fetching and compilation are cached under .ignite/plugins folder. A new command `ignite plugin` has been added to manage plugins and make new ones. To give plugins the ability to load the chain, the function `cmd.NewChainWithHomeFlags` is now public.
use hashicorp/go-plugin 1.4.4 to skip warning message
tbruyelle
requested review from
ilgooz,
aljo242,
lumtis,
jeronimoalbi and
fadeev
as code owners
Closed
CI doesn't have any default git config.
aljo242
reviewed
Oct 5, 2022
we don't, but I'll add it and remove the go.sum 👍 |
aljo242
previously approved these changes
Oct 7, 2022
@aljo242 I removed the go.sum and also all the indirect dependencies (we could probably do that also for chain |
aljo242
reviewed
Oct 20, 2022
aljo242
previously approved these changes
Oct 20, 2022
jeronimoalbi
previously approved these changes
Oct 21, 2022
aljo242
reviewed
Oct 25, 2022
aljo242
approved these changes
Oct 31, 2022
This was referenced Nov 3, 2022
Closed
Closed
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
* feat: plugin system A plugin is a binary that can communicate with ignite using github.com/hashicorp/go-plugin. When ignite is executed under a chain configuration, it checks if the config contains plugins. If yes the plugins are fetched, compiled and ran, which will add more commands to the existing ones. Fetching and compilation are cached under .ignite/plugins folder. A new command `ignite plugin` has been added to manage plugins and make new ones. To give plugins the ability to load the chain, the function `cmd.NewChainWithHomeFlags` is now public. * update plugin go.mod use hashicorp/go-plugin 1.4.4 to skip warning message * add plugin go.sum * git init and commit scaffolded plugins * update CL * fix dependecy issue * fix missing commit author when no default config CI doesn't have any default git config. * fix linter * Update ignite/services/plugin/template/main.go.plush Co-authored-by: Alex Johnson <[email protected]> * remove plugin go.sum and use gocmd * Update ignite/services/plugin/plugin.go Co-authored-by: Jerónimo Albi <[email protected]> * remove commented line * fix cannot use cmd.Context() there bc it's nil * kill plugin client at the end of execution * fix comment * improve error handling in LoadPlugins * remove plugin.Name The field has no real usage, it was here to have a shorter name than the path but dealing with the path is actually less confusing. * fix readme for plugins * fix: ensure plugin instances are killed * update main so defer funcs are honored * use const exit codes * go mod tidy * fix due to plushgen removal * add PR id to CL * change CL version * fix CL Co-authored-by: Alex Johnson <[email protected]> Co-authored-by: Jerónimo Albi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A plugin is a binary that can communicate with ignite using
github.com/hashicorp/go-plugin. When ignite is executed under a chain
configuration, it checks if the config contains plugins. If yes the
plugins are fetched, compiled and ran, which will add more commands to
the existing ones.
Fetching and compilation are cached under .ignite/plugins folder.
A new command
ignite pluginhas been added to manage plugins and make newones.
To give plugins the ability to load the chain, the function
cmd.NewChainWithHomeFlagsis now public.This is a rebase of #1959, with some small additional changes: