Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Akash deployment support #1900

Closed
wants to merge 3 commits into from

Conversation

Xuefeng-Zhu
Copy link

add bootstrap file to allow developer to quickly deploy to Akash

@Xuefeng-Zhu Xuefeng-Zhu changed the title add Akash deployment support feat: add Akash deployment support Dec 8, 2021
Copy link
Collaborator

@Pantani Pantani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏽

@@ -0,0 +1,21 @@

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try to avoid scaffolding a makefile only for this, please?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is needed to Akash docker image to build the project. I think it is also useful to provide a option to allow users to build the project without install Starport

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use the starport chain build command. And if you are scaffolding a module with starport, you already have it installed. The build should be for developers. The users should manage the signed binary.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Akash need to build a docker image, and docker image does not have starport installed. Moreover, it will use make install to install the node binary. https://github.com/ovrclk/cosmos-omnibus/blob/master/Dockerfile#L25

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can run the commands into the Dockerfile. The Makefile is not necessary.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Makefile is used across for all projects in cosmos-omnibus

Copy link
Contributor

@fadeev fadeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Xuefeng-Zhu we're big fans of Akash! I was wondering, is it possible to keep these files in a separate directory akash, so that users don't get confused as to what these files relate to. Also, I don't think we should scaffold third-party config files by default. starport scaffold akash starport generate akash looks appropriate.

Copy link
Collaborator

@Pantani Pantani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should not create these files by default. We can use something like the starport generate akash command

@@ -0,0 +1,21 @@

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use the starport chain build command. And if you are scaffolding a module with starport, you already have it installed. The build should be for developers. The users should manage the signed binary.

@@ -0,0 +1,45 @@
---
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use akash folder instead of deploy?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@Xuefeng-Zhu
Copy link
Author

@Xuefeng-Zhu we're big fans of Akash! I was wondering, is it possible to keep these files in a separate directory akash, so that users don't get confused as to what these files relate to. Also, I don't think we should scaffold third-party config files by default. starport scaffold akash starport generate akash looks appropriate.

Sounds good

@Xuefeng-Zhu
Copy link
Author

@Pantani I have addressed the comment

@tombeynon
Copy link

Hi all - I'm one of the maintainers of cosmos-omnibus and found this PR, thought I'd give some background. Akash can ultimately run any published docker image, Omnibus just provides a standardised init, restore and config, and scripts to backup/restore keys and node data. This makes it simple to run a node anywhere, but particularly on Akash with it's ephemeral storage.

Adding a chain to Omnibus needs two things:

We recently added an optional Starport build option to build binaries using starport chain build to support cheqd so the config in that PR might be the best one to base this PR on.

Having said that, I'm not sure the Omnibus addition can be entirely generated like this as it requires a few file updates currently. It might be better just to document the process - I could add something to the Omnibus README or Wiki? We have a few changes planned there anyway

@ilgooz
Copy link
Member

ilgooz commented Jan 3, 2022

@tombeynon hey, we're in the process of implementing a plugin system #1312 which will allow you to add custom commands to Starport CLI. Implementing a command like starport deploy omnibus could be possible with Starport Plugins and may help to solve the problem about modifying files.

@aljo242
Copy link
Contributor

aljo242 commented Nov 7, 2022

#2877 has been merged, so perhaps this PR can be revisited!

@aljo242
Copy link
Contributor

aljo242 commented Dec 5, 2022

Closing due to inactivity. If you'd like to revisit this issue, please open a new PR!

We will also be working on adding akash functionality in a plugin in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants