Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider refactoring plugin code in services/chain #3049

Closed
Tracked by #3028
aljo242 opened this issue Nov 3, 2022 · 1 comment · Fixed by #3062
Closed
Tracked by #3028

Consider refactoring plugin code in services/chain #3049

aljo242 opened this issue Nov 3, 2022 · 1 comment · Fixed by #3062

Comments

@aljo242
Copy link
Contributor

aljo242 commented Nov 3, 2022

With the addition of a true Plugin system (#2877), we have some a confusing concept in the codebase with the same name.

The idea of this system seems to have been a "plugable" system where different versions of chains could be configured using different logic. With a unified set of logic since Launchpad chains have been deprecated, and the push to remove all associated code from cli in #3033, we should reconsider how this code works - especially because it is much less of a "Plugin" system than what we added in #2877.

Right now, type Plugin is an interface but we only have one implementation for it (stargate plugin). It is very likely that there will only be one implementation from now on, but keeping it as an interface allows us to be flexible in the future.

I suggest that we keep the interface and mainly change the naming:

plugin -> runtimeConfig

From there, some of the logic existing in services/chain/plugin-stargate.go can be removed since it is no longer necessary. Example: func SupportsIBC() is no longer needed because all versions support IBC.

@lumtis
Copy link
Contributor

lumtis commented Nov 3, 2022

I'm would be more in favor of removing it personally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants