You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With the addition of a true Plugin system (#2877), we have some a confusing concept in the codebase with the same name.
The idea of this system seems to have been a "plugable" system where different versions of chains could be configured using different logic. With a unified set of logic since Launchpad chains have been deprecated, and the push to remove all associated code from cli in #3033, we should reconsider how this code works - especially because it is much less of a "Plugin" system than what we added in #2877.
Right now, type Plugin is an interface but we only have one implementation for it (stargate plugin). It is very likely that there will only be one implementation from now on, but keeping it as an interface allows us to be flexible in the future.
I suggest that we keep the interface and mainly change the naming:
plugin -> runtimeConfig
From there, some of the logic existing in services/chain/plugin-stargate.go can be removed since it is no longer necessary. Example: func SupportsIBC() is no longer needed because all versions support IBC.
The text was updated successfully, but these errors were encountered:
With the addition of a true
Plugin
system (#2877), we have some a confusing concept in the codebase with the same name.The idea of this system seems to have been a "plugable" system where different versions of chains could be configured using different logic. With a unified set of logic since
Launchpad
chains have been deprecated, and the push to remove all associated code from cli in #3033, we should reconsider how this code works - especially because it is much less of a "Plugin" system than what we added in #2877.Right now,
type Plugin
is aninterface
but we only have one implementation for it (stargate plugin). It is very likely that there will only be one implementation from now on, but keeping it as an interface allows us to be flexible in the future.I suggest that we keep the interface and mainly change the naming:
From there, some of the logic existing in
services/chain/plugin-stargate.go
can be removed since it is no longer necessary. Example:func SupportsIBC()
is no longer needed because all versions support IBC.The text was updated successfully, but these errors were encountered: